From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Eugene Syromiatnikov <esyr@redhat.com>,
Matt Johnston <matt@codeconstruct.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] MCTP sockaddr padding check/initialisation fixup
Date: Tue, 02 Nov 2021 09:57:34 +0800 [thread overview]
Message-ID: <b8c77eb3b3379e52e91b9ecc9c35c2f707cc3ae5.camel@codeconstruct.com.au> (raw)
In-Reply-To: <cover.1635788968.git.esyr@redhat.com>
Hi Eugene,
> Padding/reserved fields necessitate appropriate checks in order to be
> usable in the future.
We don't have a foreseeable need for extra fields here; so this is a bit
hypothetical at the moment. However, I guess there may be something that
comes up in future - was there something you have in mind?
The requirements for the padding bytes to be zero on sendmsg() will
break the ABI for applications that are using the interface on 5.15;
there's a small, contained set of those at the moment though, so I'm OK
to handle the updates if this patch is accepted, but we'd need to make a
call on that soon.
Setting the pad bytes to zero on recvmsg() is a good plan though, I'm
happy for that change to go in regardless.
Cheers,
Jeremy
next prev parent reply other threads:[~2021-11-02 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:54 [PATCH net-next 0/2] MCTP sockaddr padding check/initialisation fixup Eugene Syromiatnikov
2021-11-01 17:54 ` [PATCH net-next 1/2] mctp: handle the struct sockaddr_mctp padding fields Eugene Syromiatnikov
2021-11-01 17:54 ` [PATCH net-next 2/2] mctp: handle the struct sockaddr_mctp_ext padding field Eugene Syromiatnikov
2021-11-03 0:55 ` Jakub Kicinski
2021-11-02 1:57 ` Jeremy Kerr [this message]
2021-11-02 8:50 ` [PATCH net-next 0/2] MCTP sockaddr padding check/initialisation fixup Eugene Syromiatnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c77eb3b3379e52e91b9ecc9c35c2f707cc3ae5.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=esyr@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).