linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, sashal@kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	sstabellini@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	osalvador@suse.com, Michal Hocko <mhocko@suse.com>,
	pasha.tatashin@soleen.com,
	Dan Williams <dan.j.williams@intel.com>,
	richard.weiyang@gmail.com, Qian Cai <cai@lca.pw>,
	linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
	Linux-MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Remove __online_page_set_limits()
Date: Tue, 10 Sep 2019 14:58:19 +0200	[thread overview]
Message-ID: <b8ceaa6f-a0b3-515f-4d11-c9a633eb95c4@redhat.com> (raw)
In-Reply-To: <CAFqt6zZNHGdgaiiRvz-1AFe5g1652oyZpNQidK1V0B6weQHz0w@mail.gmail.com>

On 10.09.19 14:56, Souptick Joarder wrote:
> On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>>
>> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
>>> __online_page_set_limits() is a dummy function and an extra call
>>> to this can be avoided.
>>>
>>> As both of the callers are now removed, __online_page_set_limits()
>>> can be removed permanently.
>>>
>>> Souptick Joarder (3):
>>>   hv_ballon: Avoid calling dummy function __online_page_set_limits()
>>>   xen/ballon: Avoid calling dummy function __online_page_set_limits()
>>>   mm/memory_hotplug.c: Remove __online_page_set_limits()
>>>
>>>  drivers/hv/hv_balloon.c        | 1 -
>>>  drivers/xen/balloon.c          | 1 -
>>>  include/linux/memory_hotplug.h | 1 -
>>>  mm/memory_hotplug.c            | 5 -----
>>>  4 files changed, 8 deletions(-)
>>
>> Do we really need 3 separate patches to remove 8 lines of code?
> 
> I prefer to split into series of 3 which looks more clean. But I am ok
> with other option.
> Would you like to merge into single one ?
> 

If you have to resend, you could squash them into one. If not, I think
this is okay ...

-- 

Thanks,

David / dhildenb

      reply	other threads:[~2019-09-10 12:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07 21:47 Souptick Joarder
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
2019-09-09  7:54   ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
2019-09-08  5:09   ` Juergen Gross
2019-09-09  7:54   ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
2019-09-09  7:54   ` David Hildenbrand
2019-09-09  8:12 ` [PATCH 0/3] " Michal Hocko
2019-09-09 15:42 ` Kirill A. Shutemov
2019-09-10 12:56   ` Souptick Joarder
2019-09-10 12:58     ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8ceaa6f-a0b3-515f-4d11-c9a633eb95c4@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=cai@lca.pw \
    --cc=dan.j.williams@intel.com \
    --cc=haiyangz@microsoft.com \
    --cc=jgross@suse.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kirill@shutemov.name \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=richard.weiyang@gmail.com \
    --cc=sashal@kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH 0/3] Remove __online_page_set_limits()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).