From: Can Guo <cang@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com,
beanhuo@micron.com, asutoshd@codeaurora.org,
matthias.bgg@gmail.com, bvanassche@acm.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
andy.teng@mediatek.com, chaotian.jing@mediatek.com,
cc.chou@mediatek.com, jiajie.hao@mediatek.com,
alice.chao@mediatek.com, huadian.liu@mediatek.com
Subject: Re: [PATCH v1 3/3] scsi: ufs: Introduce notify_event variant function
Date: Thu, 03 Dec 2020 13:49:05 +0800 [thread overview]
Message-ID: <b8d2d4e45e1738865925de17d53dcaa7@codeaurora.org> (raw)
In-Reply-To: <20201126053839.25889-4-stanley.chu@mediatek.com>
On 2020-11-26 13:38, Stanley Chu wrote:
> Introduce notify_event variant function to allow
> vendor to get notified of important events and connect
> to any proprietary debugging facilities.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 ++
> drivers/scsi/ufs/ufshcd.h | 11 +++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 7194bed1f10b..63fe37e1c908 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4484,6 +4484,8 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val)
> e->val[e->pos] = val;
> e->tstamp[e->pos] = ktime_get();
> e->pos = (e->pos + 1) % UFS_EVENT_HIST_LENGTH;
> +
> + ufshcd_vops_notify_event(hba, id, &val);
> }
> EXPORT_SYMBOL_GPL(ufshcd_update_evt_hist);
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 82c2fc5597bb..a81ca36c1715 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -317,6 +317,7 @@ struct ufs_pwr_mode_info {
> * @phy_initialization: used to initialize phys
> * @device_reset: called to issue a reset pulse on the UFS device
> * @program_key: program or evict an inline encryption key
> + * @notify_event: called to notify important events
> */
> struct ufs_hba_variant_ops {
> const char *name;
> @@ -352,6 +353,8 @@ struct ufs_hba_variant_ops {
> void *data);
> int (*program_key)(struct ufs_hba *hba,
> const union ufs_crypto_cfg_entry *cfg, int slot);
> + void (*notify_event)(struct ufs_hba *hba,
> + enum ufs_event_type evt, void *data);
> };
>
> /* clock gating state */
> @@ -1097,6 +1100,14 @@ static inline int
> ufshcd_vops_clk_scale_notify(struct ufs_hba *hba,
> return 0;
> }
>
> +static inline void ufshcd_vops_notify_event(struct ufs_hba *hba,
> + enum ufs_event_type evt,
> + void *data)
> +{
> + if (hba->vops && hba->vops->notify_event)
> + hba->vops->notify_event(hba, evt, data);
> +}
> +
> static inline int ufshcd_vops_setup_clocks(struct ufs_hba *hba, bool
> on,
> enum ufs_notify_change_status status)
> {
Reviewed-by: Can Guo <cang@codeaurora.org>
next prev parent reply other threads:[~2020-12-03 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 5:38 [PATCH v1 0/3] Refine error history and introduce notify_event vop Stanley Chu
2020-11-26 5:38 ` [PATCH v1 1/3] scsi: ufs: Add error history for abort event in UFS Device W-LUN Stanley Chu
2020-12-03 5:33 ` Can Guo
2020-11-26 5:38 ` [PATCH v1 2/3] scsi: ufs: Refine error history functions Stanley Chu
2020-12-03 5:46 ` Can Guo
2020-11-26 5:38 ` [PATCH v1 3/3] scsi: ufs: Introduce notify_event variant function Stanley Chu
2020-12-03 5:49 ` Can Guo [this message]
2020-12-05 2:45 ` [PATCH v1 0/3] Refine error history and introduce notify_event vop Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d2d4e45e1738865925de17d53dcaa7@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=huadian.liu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).