From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] tools: iio: Rename generic_buffer to iio_generic_buffer
Date: Sun, 29 May 2016 19:58:11 +0100 [thread overview]
Message-ID: <b9311dd5-dc86-6a86-5cc1-84d17dd3108a@kernel.org> (raw)
In-Reply-To: <1464102235-11360-1-git-send-email-daniel.baluta@intel.com>
On 24/05/16 16:03, Daniel Baluta wrote:
> This makes it clear that generic_buffer is an IIO tool
> and also complies with filename conventions in tools/iio.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Pretty uncontroversial bit of common sense to my mind ;)
Applied to the togreg branch of iio.git with a few changes to merge it with
recent install patch.
Pushed out as testing for the autobuilders to ignore it (probably).
Thanks,
Jonathan
> ---
> Changes since v1:
> * use -M to detect renames and make the patch easier to review
>
> tools/iio/Makefile | 6 +++---
> tools/iio/{generic_buffer.c => iio_generic_buffer.c} | 0
> 2 files changed, 3 insertions(+), 3 deletions(-)
> rename tools/iio/{generic_buffer.c => iio_generic_buffer.c} (100%)
>
> diff --git a/tools/iio/Makefile b/tools/iio/Makefile
> index 3a7a54f..e8a009b 100644
> --- a/tools/iio/Makefile
> +++ b/tools/iio/Makefile
> @@ -1,16 +1,16 @@
> CC = $(CROSS_COMPILE)gcc
> CFLAGS += -Wall -g -D_GNU_SOURCE
>
> -all: iio_event_monitor lsiio generic_buffer
> +all: iio_event_monitor lsiio iio_generic_buffer
>
> iio_event_monitor: iio_event_monitor.o iio_utils.o
>
> lsiio: lsiio.o iio_utils.o
>
> -generic_buffer: generic_buffer.o iio_utils.o
> +iio_generic_buffer: iio_generic_buffer.o iio_utils.o
>
> %.o: %.c iio_utils.h
>
> .PHONY: clean
> clean:
> - rm -f *.o iio_event_monitor lsiio generic_buffer
> + rm -f *.o iio_event_monitor lsiio iio_generic_buffer
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/iio_generic_buffer.c
> similarity index 100%
> rename from tools/iio/generic_buffer.c
> rename to tools/iio/iio_generic_buffer.c
>
prev parent reply other threads:[~2016-05-29 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 15:03 [RFC PATCH v2] tools: iio: Rename generic_buffer to iio_generic_buffer Daniel Baluta
2016-05-29 18:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9311dd5-dc86-6a86-5cc1-84d17dd3108a@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).