From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
devicetree@vger.kernel.org
Cc: jassisinghbrar@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
git@xilinx.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] dt-bindings: mailbox: zynqmp_ipi: convert to yaml
Date: Fri, 29 Apr 2022 23:11:09 +0200 [thread overview]
Message-ID: <b938c48f-7959-5622-9d09-aeb8c11da979@linaro.org> (raw)
In-Reply-To: <20220428165004.3212654-1-shubhrajyoti.datta@xilinx.com>
On 28/04/2022 18:50, Shubhrajyoti Datta wrote:
> Convert the ipi doc to yaml.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v2:
(...)
> +maintainers:
> + - Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> +
> +properties:
> + compatible:
> + const: xlnx,zynqmp-ipi-mailbox
> +
> + method:
> + description: |
> + The method of calling the PM-API firmware layer.
> + Permitted values are.
> + - "smc" : SMC #0, following the SMCCC
> + - "hvc" : HVC #0, following the SMCCC
Wrong alignment of entire description.
> +
> + $ref: /schemas/types.yaml#/definitions/string-array
This does not look like string array, but regular string.
> + enum:
> + - smc
> + - hvc
> + default: smc
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + xlnx,ipi-id:
> + description: |
> + Remote Xilinx IPI agent ID of which the mailbox is connected to.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + interrupts:
> + maxItems: 1
> +
> + ranges: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - interrupts
> + - '#address-cells'
> + - '#size-cells'
Missing required xlnx,ipi-id. Such change was not explained in commit msg.
> +
> +patternProperties:
Put patternProperties just after "properties".
> + '^mailbox@[0-9a-f]+$':
> + description: Internal ipi mailbox node
> + type: object # DT nodes are json objects
> + properties:
> + xlnx,ipi-id:
> + description:
> + Remote Xilinx IPI agent ID of which the mailbox is connected to.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + "#mbox-cells":
Wrong quotes. Keep it consistent.
> + const: 1
> + description:
> + It contains tx(0) or rx(1) channel IPI id number.
No need for double space ^^.
> +
> + reg:
> + maxItems: 4
> +
> + reg-names:
> + items:
> + - const: local_request_region
> + - const: local_response_region
> + - const: remote_request_region
> + - const: remote_response_region
> +
> +
> + required:
> + - reg
> + - "#mbox-cells"
Missing required properties.
> +
> +examples:
> + - |
> + amba {
> + #address-cells = <0x2>;
> + #size-cells = <0x2>;
> + zynqmp_ipi {
Generic node names (mailbox?), no underscores in node names.
> + compatible = "xlnx,zynqmp-ipi-mailbox";
> + interrupts = <0 29 4>;
interrupts look like common flags, so use defines.
> + xlnx,ipi-id = <0>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ipi_mailbox_rpu0: mailbox@ff9905c0 {
> + reg = <0x0 0xff9905c0 0x0 0x20>,
> + <0x0 0xff9905e0 0x0 0x20>,
> + <0x0 0xff990e80 0x0 0x20>,
> + <0x0 0xff990ea0 0x0 0x20>;
> + reg-names = "local_request_region",
> + "local_response_region",
These needs alignment with first string.
> + "remote_request_region",
> + "remote_response_region";
> + #mbox-cells = <1>;
> + xlnx,ipi-id = <4>;
> + };
> + };
> + };
> +
> + rpu0 {
> + mboxes = <&ipi_mailbox_rpu0 0>,
> + <&ipi_mailbox_rpu0 1>;
> + mbox-names = "tx", "rx";
> + };
Skip consumer example, it's obvious.
> +...
Best regards,
Krzysztof
prev parent reply other threads:[~2022-04-29 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 16:50 [PATCH v4] dt-bindings: mailbox: zynqmp_ipi: convert to yaml Shubhrajyoti Datta
2022-04-29 21:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b938c48f-7959-5622-9d09-aeb8c11da979@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).