From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=QHyQ=ZU=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 40F7BC432C0
	for <linux-kernel@archiver.kernel.org>; Thu, 28 Nov 2019 09:26:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 17762216F4
	for <linux-kernel@archiver.kernel.org>; Thu, 28 Nov 2019 09:26:33 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="UpRTzl3/"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726917AbfK1J0c (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 28 Nov 2019 04:26:32 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:14597 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726092AbfK1J0b (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 28 Nov 2019 04:26:31 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ddf92c90001>; Thu, 28 Nov 2019 01:26:33 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 28 Nov 2019 01:26:29 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 28 Nov 2019 01:26:29 -0800
Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Nov
 2019 09:26:27 +0000
Subject: Re: [PATCH 4.4 000/159] 4.4.203-stable review
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Guenter Roeck <linux@roeck-us.net>, <linux-kernel@vger.kernel.org>,
        <torvalds@linux-foundation.org>, <akpm@linux-foundation.org>,
        <shuah@kernel.org>, <patches@kernelci.org>,
        <ben.hutchings@codethink.co.uk>, <lkft-triage@lists.linaro.org>,
        <stable@vger.kernel.org>, linux-tegra <linux-tegra@vger.kernel.org>
References: <20191122100704.194776704@linuxfoundation.org>
 <f0f505ae-5113-1abd-d4f7-0c3535c83de4@nvidia.com>
 <20191122133931.GA2033651@kroah.com> <20191122134131.GA2050590@kroah.com>
 <20191122134627.GB2050590@kroah.com>
 <9f976044-2dbc-6c19-11e7-210cd7ab35ea@nvidia.com>
 <a5d68f07-5f9a-2809-404d-bcd8ca593d70@roeck-us.net>
 <7edc9531-347e-9ac7-2583-5efb49acffdb@nvidia.com>
 <20191125094116.GA2340170@kroah.com>
 <a6830303-ff96-f7df-b504-ab226aefddca@nvidia.com>
 <20191125160305.GD2683321@kroah.com>
 <013aa2b3-9a68-6227-36bc-093d03547fce@nvidia.com>
Message-ID: <b93b699e-35d9-1082-b46b-a2c7400b7b48@nvidia.com>
Date:   Thu, 28 Nov 2019 09:26:25 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <013aa2b3-9a68-6227-36bc-093d03547fce@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1574933193; bh=KTVoMSSyf9foSllBBmUsDqTGyvZdQUAHe78ZBGcVLgU=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=UpRTzl3/X1MGeIjegbw27qweF4KXJ6s21zW+qeh7DsFuaGxGq8pDv+il16dRgTQAr
         XimoDtDK8f9Hzww6BdwQnXLlfHzAYmWewzOpbVEz0zqfSZSz2fsmzz7fDRDcxMVDMH
         1LwrCLpfXX9dzqxzSclpFeErQASp04n+eb5Cc06WULuXBrJOJWLSNV7vAZjH9LZSaJ
         63KNoFLu451Ej5VApPGOe5LbDSlQy4iaSDoHYf3239WB/V4lSOrCXyv8CRbLWDg62B
         BU2ISEc1ND+cr0ia5UuKSpK5kcA2D3opDc3AkwC1S78FChi46+T0TLy/8/JBnNXDpE
         NNe2G+nqHnh2A==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 25/11/2019 22:45, Jon Hunter wrote:
>=20
> On 25/11/2019 16:03, Greg Kroah-Hartman wrote:
>> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote:
>>>
>>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
>>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
>>>>>
>>>>> On 23/11/2019 15:46, Guenter Roeck wrote:
>>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
>>>>>>
>>>>>> [ ... ]
>>>>>>
>>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or p=
ath
>>>>>>> dwc3 not found
>>>>>>> FATAL ERROR: Syntax error parsing input tree
>>>>>>> scripts/Makefile.lib:293: recipe for target
>>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>>>>>>> make: *** [dtbs] Error 2
>>>>>>>
>>>>>>>
>>>>>>> This is caused by the following commit ...
>>>>>>>
>>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>>>>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>>>>>>> Date:=C2=A0=C2=A0 Fri Sep 28 17:54:00 2018 +0200
>>>>>>>
>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 ARM: dts: omap5: enable OTG role for DWC3 =
controller
>>>>>>>
>>>>>>
>>>>>> On top of the breakage caused by this patch, I would also argue
>>>>>> that it is not a bug fix and should not have been included
>>>>>> in the first place.
>>>>>>
>>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5=
:
>>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
>>>>>> that patch, I highly doubt that a backport to 4.4 would work.
>>>>
>>>> Good catch, I have now dropped both of these patches and pushed out a
>>>> -rc3
>>>>
>>>>> FYI ... I am still seeing a build failure because of this with -rc2 .=
..
>>>>
>>>> Can you see if -rc3 is also giving you problems?
>>>
>>> Better, but I appear to be seeing some random suspend failures with thi=
s
>>> now on one board. I will try to bisect this.
>>>
>>> Test results for stable-v4.4:
>>>     6 builds:	6 pass, 0 fail
>>>     12 boots:	12 pass, 0 fail
>>>     19 tests:	18 pass, 1 fail
>>>
>>> Linux version:	4.4.203-rc3-g2576206c30b5
>>> Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
>>>                 tegra30-cardhu-a04
>>
>> Odd.  If you find anything interesting, please let me know.
>=20
> Yes will do. Bisect has not found anything yet, so will keeping looking
> to see if this is a false-positive or not.

I have been doing some more testing and it appears that I see
intermittent suspend failures on Tegra124 with linux-4.4.y. Apparently
this issue has always been there and appears to be fixed in v4.5. I am
still trying to find a way to fix this. The changes in v4.5 that appear
to resolve this are too complex for stable (several patches in Tegra clk
drivers). Anyway, ignore this for now, I will see how we can fix or
workaround for linux-4.4.y.

Jon

--=20
nvpublic