linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Luke D. Jones" <luke@ljones.dev>, linux-kernel@vger.kernel.org
Cc: hadess@hadess.net, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 0/1] asus-wmi: Add support for custom fan curves
Date: Fri, 20 Aug 2021 12:05:15 +0200	[thread overview]
Message-ID: <b94a452c-696f-d879-d239-701223c8caff@redhat.com> (raw)
In-Reply-To: <20210820095726.14131-1-luke@ljones.dev>

Hi Luke,
On 8/20/21 11:57 AM, Luke D. Jones wrote:
> Add support for custom fan curves found on some ASUS ROG laptops.
> 
> The patch has gone through a few revisions as others tested it and
> requested bahaviour changes or reported issues. V4 should be considered
> finalised for now and I won't submit a new version until V4 has been
> reviewed.
> 
> - V1
>   + Initial patch work
> - V2
>   + Don't fail and remove wmi driver if error from
>     asus_wmi_evaluate_method_buf() if error is -ENODEV
> - V3
>   + Store the "default" fan curves
>   + Call throttle_thermal_policy_write() if a curve is erased to ensure
>     that the factory default for a profile is applied again
> - V4
>   + Do not apply default curves by default. Testers have found that the
>     default curves don't quite match actual no-curve behaviours
>   + Add method to enable/disable curves for each profile

You are sending new revisions pretty fast. I don't really have an issue
with that, but can you let me know when you think this has stabilized
a bit ?  Then I can review it when it is not changing so much anymore :)

Regards,

Hans


  parent reply	other threads:[~2021-08-20 10:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  9:57 [PATCH v4 0/1] asus-wmi: Add support for custom fan curves Luke D. Jones
2021-08-20  9:57 ` [PATCH v4 1/1] " Luke D. Jones
2021-08-20 10:18   ` Bastien Nocera
2021-08-20 10:33     ` Luke Jones
2021-08-20 10:43       ` Bastien Nocera
2021-08-20 10:51         ` Bastien Nocera
2021-08-20 11:00           ` Luke Jones
2021-08-20 11:39             ` Bastien Nocera
2021-08-20 21:30               ` Luke Jones
2021-08-23 10:28                 ` Bastien Nocera
2021-08-23 11:26                   ` Luke Jones
2021-08-23 11:45                     ` Hans de Goede
2021-08-24 12:33                       ` Bastien Nocera
2021-08-24 15:45                         ` Hans de Goede
2021-08-20 10:59         ` Luke Jones
2021-08-20 10:05 ` Hans de Goede [this message]
2021-08-20 10:08   ` [PATCH v4 0/1] " Luke Jones
2021-08-26 23:09 ` Luke Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b94a452c-696f-d879-d239-701223c8caff@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=hadess@hadess.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).