From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57756C63777 for ; Wed, 18 Nov 2020 10:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06D0F206A5 for ; Wed, 18 Nov 2020 10:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbgKRKqC (ORCPT ); Wed, 18 Nov 2020 05:46:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7699 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727065AbgKRKqB (ORCPT ); Wed, 18 Nov 2020 05:46:01 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cbfbm5mLxzkY67; Wed, 18 Nov 2020 18:45:40 +0800 (CST) Received: from [10.174.179.81] (10.174.179.81) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 18 Nov 2020 18:45:58 +0800 Subject: Re: [PATCH] android/ion: fix error return code in opensocket() From: "wanghai (M)" To: , CC: , References: <20201118103918.58477-1-wanghai38@huawei.com> Message-ID: Date: Wed, 18 Nov 2020 18:45:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201118103918.58477-1-wanghai38@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.81] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a syntax problem with this patch, please ignore it! ÔÚ 2020/11/18 18:39, Wang Hai дµÀ: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer sharing") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- > tools/testing/selftests/android/ion/ipcsocket.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/android/ion/ipcsocket.c b/tools/testing/selftests/android/ion/ipcsocket.c > index 7dc521002095..268e6b610357 100644 > --- a/tools/testing/selftests/android/ion/ipcsocket.c > +++ b/tools/testing/selftests/android/ion/ipcsocket.c > @@ -28,8 +28,9 @@ int opensocket(int *sockfd, const char *name, int connecttype) > } > > *sockfd = ret; > - if (setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR, > - (char *)&temp, sizeof(int)) < 0) { > + ret = setsockopt(*sockfd, SOL_SOCKET, SO_REUSEADDR, (char *)&temp, > + sizeof(int)) > + if (ret < 0) { > fprintf(stderr, "<%s>: Failed setsockopt: <%s>\n", > __func__, strerror(errno)); > goto err;