From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE22DC433DF for ; Mon, 20 Jul 2020 16:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B1F420656 for ; Mon, 20 Jul 2020 16:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WEaPnjNZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388243AbgGTQTR (ORCPT ); Mon, 20 Jul 2020 12:19:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387565AbgGTQMS (ORCPT ); Mon, 20 Jul 2020 12:12:18 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CFA9C0619D2 for ; Mon, 20 Jul 2020 09:12:18 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so18412167wrs.11 for ; Mon, 20 Jul 2020 09:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ziX/dm0RLSDUr/q7kPIheAPGvEUSPjbonaq0OAEdF6I=; b=WEaPnjNZalZ7tz0+C8Y6Cpmd8HMejbH+0HcF6PMZfxmydwOCdwsyLHWmEmRkgJ4WP8 FQheQNqLSevKtoVfzrB4ryN4A8sVWdGDuFYXO4mvcthMpeO9c+l7L48zi0nakASXPmgd mAfvkpNH8cdNYMgb3zjgHnYYmn4ZgLbX572Y4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ziX/dm0RLSDUr/q7kPIheAPGvEUSPjbonaq0OAEdF6I=; b=JRV8WhkItWuToFO+jYv1hK8eAmWp51ErkbBZ3GylGFQZuTkF5u6H6BGv8eY2chkSHo NPkj+v3QBOSXKc8IN2G+mQr6TOHqIMxFPQnvJlZSCw4eS898y2H7BxMWGgSvva0h8pw1 M1+W+zXhLhVTvaD3z1HTDTw/NrPCJWpZQTsBydU+mTKX3B0pzHjDoLY/in4OQ5ZWgNjw nyqplxTilmCqMmuoONstZj/F5LtxV3ks8J2Ic4TjbOK/kGQP0LgH0ddgBZA11GuutNzk H3AytcifVZZcbfKq4sFI5LBhDNFE5oefg3EbC/ykfH2/0XrK0uUtoDR8aZiEMNjXZtJa q+Xw== X-Gm-Message-State: AOAM531nWaeLRi5Pn7zIrkq0gHeGxa8WYKrKvCXqKXpFGeLBuqPJzENi BW/Bih+TmSvEhDEUvm6SrYYABw== X-Google-Smtp-Source: ABdhPJwvBH+5Jd3N3gObiF6ptroAC12fJ0YwtBnlcvNbCK74D2txG+ORcQcfnuD0aui297M7pb6bbw== X-Received: by 2002:a5d:6085:: with SMTP id w5mr15577771wrt.348.1595261536594; Mon, 20 Jul 2020 09:12:16 -0700 (PDT) Received: from [10.136.8.242] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id u15sm35142795wrm.64.2020.07.20.09.12.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 09:12:15 -0700 (PDT) Subject: Re: [PATCH] clk: iproc: round clock rate to the closest To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Lori Hikichi References: <20200612225212.124301-1-ray.jui@broadcom.com> From: Ray Jui Message-ID: Date: Mon, 20 Jul 2020 09:12:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200612225212.124301-1-ray.jui@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen/Michael, Could you please help to review this patch? Thanks, Ray On 6/12/2020 3:52 PM, Ray Jui wrote: > From: Lori Hikichi > > Change from 'DIV_ROUND_UP' to 'DIV_ROUND_CLOSEST' when calculating the > clock divisor in the iProc ASIU clock driver to allow to get to the > closest clock rate. > > Fixes: 5fe225c105fd ("clk: iproc: add initial common clock support") > Signed-off-by: Lori Hikichi > Signed-off-by: Ray Jui > --- > drivers/clk/bcm/clk-iproc-asiu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/bcm/clk-iproc-asiu.c b/drivers/clk/bcm/clk-iproc-asiu.c > index 6fb8af506777..e062dd4992ea 100644 > --- a/drivers/clk/bcm/clk-iproc-asiu.c > +++ b/drivers/clk/bcm/clk-iproc-asiu.c > @@ -119,7 +119,7 @@ static long iproc_asiu_clk_round_rate(struct clk_hw *hw, unsigned long rate, > if (rate == *parent_rate) > return *parent_rate; > > - div = DIV_ROUND_UP(*parent_rate, rate); > + div = DIV_ROUND_CLOSEST(*parent_rate, rate); > if (div < 2) > return *parent_rate; > > @@ -145,7 +145,7 @@ static int iproc_asiu_clk_set_rate(struct clk_hw *hw, unsigned long rate, > return 0; > } > > - div = DIV_ROUND_UP(parent_rate, rate); > + div = DIV_ROUND_CLOSEST(parent_rate, rate); > if (div < 2) > return -EINVAL; > >