From: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: [Outreachy kernel][PATCH 1/4] Replace macro function by static inline function in file iss.c
Date: Mon, 12 Apr 2021 09:32:34 -0300 [thread overview]
Message-ID: <b963fdc8ef989e5505b26d0c8f91315ea26c4899.1618230425.git.alinesantanacordeiro@gmail.com> (raw)
In-Reply-To: <cover.1618230425.git.alinesantanacordeiro@gmail.com>
Replace macro function by static inline function.
Issue suggested by Julia.
Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index c89f268a..3bbc39e 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -27,22 +27,24 @@
#include "iss.h"
#include "iss_regs.h"
-#define ISS_PRINT_REGISTER(iss, name)\
- dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \
- iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name))
+static inline iss_print_register(iss, name)
+{
+ dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
+ iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name));
+}
static void iss_print_status(struct iss_device *iss)
{
dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n");
- ISS_PRINT_REGISTER(iss, HL_REVISION);
- ISS_PRINT_REGISTER(iss, HL_SYSCONFIG);
- ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5));
- ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5));
- ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5));
- ISS_PRINT_REGISTER(iss, CTRL);
- ISS_PRINT_REGISTER(iss, CLKCTRL);
- ISS_PRINT_REGISTER(iss, CLKSTAT);
+ iss_print_register(iss, HL_REVISION);
+ iss_print_register(iss, HL_SYSCONFIG);
+ iss_print_register(iss, HL_IRQSTATUS(5));
+ iss_print_register(iss, HL_IRQENABLE_SET(5));
+ iss_print_register(iss, HL_IRQENABLE_CLR(5));
+ iss_print_register(iss, CTRL);
+ iss_print_register(iss, CLKCTRL);
+ iss_print_register(iss, CLKSTAT);
dev_dbg(iss->dev, "-----------------------------------------------\n");
}
--
2.7.4
next parent reply other threads:[~2021-04-12 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1618230425.git.alinesantanacordeiro@gmail.com>
2021-04-12 12:32 ` Aline Santana Cordeiro [this message]
2021-04-12 16:05 ` [Outreachy kernel][PATCH 1/4] Replace macro function by static inline function in file iss.c kernel test robot
2021-04-12 12:32 ` [Outreachy kernel][PATCH 2/4] Replace macro function by static inline function in file iss_ipipe.c Aline Santana Cordeiro
2021-04-12 18:01 ` kernel test robot
2021-04-12 12:32 ` [Outreachy kernel][PATCH 3/4] Replace macro function by static inline function in file iss_ipipeif.c Aline Santana Cordeiro
2021-04-12 19:12 ` kernel test robot
2021-04-12 12:32 ` [Outreachy kernel][PATCH 4/4] Replace macro function by static inline function in file iss_resizer.c Aline Santana Cordeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b963fdc8ef989e5505b26d0c8f91315ea26c4899.1618230425.git.alinesantanacordeiro@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).