From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbcIAVBD (ORCPT ); Thu, 1 Sep 2016 17:01:03 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:49659 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752700AbcIAVA7 (ORCPT ); Thu, 1 Sep 2016 17:00:59 -0400 Subject: Re: [PATCH 7/8] wbt: add general throttling mechanism To: Omar Sandoval References: <1472663151-18560-1-git-send-email-axboe@fb.com> <1472663151-18560-8-git-send-email-axboe@fb.com> <20160901180523.GA3280@vader.DHCP.thefacebook.com> CC: , , , From: Jens Axboe Message-ID: Date: Thu, 1 Sep 2016 12:51:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160901180523.GA3280@vader.DHCP.thefacebook.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BY2PR0601CA0012.namprd06.prod.outlook.com (10.163.62.22) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: fdb56e08-4ad6-4480-e70d-08d3d2990b1c X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:EYXcYO74ya+BTxp4NUIEcjbuxlPmPIdAhPGrG6+/skWAO1ixQhc66G5d5GBh3MHsW27UBj6zq6/lYtTcm/eiIc6qXmRvpa2KlwkhBo3DSj1R7mLoz/0kZw0LLHidqKcQsqg90O7MX61+jM9cbxzx7qDLvF3PlCX17agQK/jDPLd6zAtpDd0W1asuYhSkoJiC;3:NTIpfncaZVnmJC89AgilaOqtx5FaZc2yt4xLAddm68DnsJ/672D1tF7deicDKWaPoZqpQPB1clj2SN11OCI7eLuZqx3A5J+t7qHuL9s2fo8LeZDp8oqhyQZNA1uMKMTF;25:5KPTUag6eMDbpPLe3mpUz2uUNaLPf2BWwP/xf8QD1X39YlwifgStEB5PYaeUhOZQTBgAuoHUr2u8m7VvLvIDVDnqYV7eHtuFNZko2Bq33lgZPRgWw/R28qdb2UEk/6sSw3To4rIQOiCf6LD2AcVNMp3JupCTeYbxBorC3sLnipALrCFkIEu6k7ps4vX5jlBmE7g17G1QmSBybJiTGt9uujX3gkEQdXRONCkoAya/26qskz5fYlYbw5Fs0Jg+Hgye0PousLQSxzowcTsBXTrDs2/OyPjQNXmpVEi9IaagOjbOyxgmAsVGzjaUnbMFO6lzgZHEGm2RpXyaroq+qAd4QopK2qH3kMPD+cBdN+IigUwjaPflLtupXyU6pxOuf4PjrgZ3WjK6B0QazlzoG2At7PpMs91pZ9DHiMMHdoqV63I= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;31:v6DdZdpUTnzPMgqFxI5a1/l4uukpM54wrfHXGalwlGOQFJ+fTgXcEQGrC1Ut+Yk2urxGZWT+LBaY5VsYNFkhsFzxmWMDts1Qks2PfpEeEr/3d0vynf355UE4nNJ0pJPWJ/0Fd6icpwuqtvis6/cze81Yu/7POVMWxdpYbae6LMLiAf24Achg1PluDS2gEOkDi8z1apVEnpduDk38dIwtQ2SyTvKJtXK/XVJTAzmUHSw=;20:QqbulzzbCpWr10ZCgHFktrQ1TbnmhKfSKr7rF2lsQq100WpDLB4cVC2Z8dnDl9lWpxwttx9jHY5HXf8q38343iueE1IsPZLD8p0+7i5nwPEp/+WE9DXkzYT3HmVGgNp3JTKqudOBhS8iqWkZdNpPb2ZVVDxAyyzYFdKI3RA3mNw=;4:v/Rg/A47NGxYBzXMJEXBvV4L/dESpQv/Vo3NNLGCM0ueN+DuUcP9Xr1/sYtjbtnmBmEcU6KwwKlUUv8LwsYOupwP1yauYlk+Lr4A4xVxYiXTd2MVnQRLN/4dTOVJUhP+xFzvt/VC3mTXezRzuu7/YDxUjZYzfFnN0++Ad9vYNvhkW05x/1tBhIKvlewFGfXEhaA+lDcK/J4RYRmdqDeenkV0Yd3NqPUmjdY1Uv1j7N4mPOEXpEll8hFNgJGjw+fY3lInnu6AQquynoL+sPymxixExSbKK7p7nM9FGy6Xrm6Ut1/60T3yxh3Ouz/51lJmETLQbN8W+ibJt0as2Kd04G1lYgjl6cIa8PqqxFeIAfk5oRHC/QDasYu0tWE5ID845kGvx8eabXoCPphQFijVGw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 0052308DC6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(199003)(24454002)(106356001)(33646002)(3846002)(6116002)(586003)(31696002)(4326007)(83506001)(189998001)(117156001)(230700001)(76176999)(92566002)(50986999)(50466002)(42186005)(68736007)(5660300001)(54356999)(2950100001)(4001350100001)(36756003)(31686004)(81156014)(81166006)(8676002)(101416001)(65826007)(105586002)(2906002)(23746002)(110136002)(97736004)(86362001)(305945005)(65956001)(66066001)(65806001)(47776003)(77096005)(7736002)(7846002)(64126003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1187;23:D9AMtMDp+nVV10TduqJgTnnTjbKXBe2u92ERd?= =?Windows-1252?Q?661iDMYgL3eg9Sndv+ECf0VU1sN6jZpQ7fnlEsjqxlHpKigwfTPDP+jw?= =?Windows-1252?Q?prWezE3OPnF7UFAiuE/zdeWGlrZGT7LgoO3l6voDTb3qOrwswxAg2by6?= =?Windows-1252?Q?GVC4o6lDITaslv0K5SLNxKv2QIqqFtAXl8oEJMDkYraKftTj46daYsQa?= =?Windows-1252?Q?1RYSUYYGVK0L3/L/kMFiNMP+zOBwJ3eaxUcoFQ2f0nnTmZQoYfRAxna6?= =?Windows-1252?Q?R1ro8tHCZqyIn/t2MJdcNdOuxKRAqtR4PzxMukNFEOWkF0Jl7/GFw33d?= =?Windows-1252?Q?e+IFyGyb5qoCD5vohFI5aq0iXWBLJ/1zwSuE+uHfYz5q2EE+qNvVk6ZU?= =?Windows-1252?Q?OXJWrH0B6NU/I2fMUko/WituVkU2LwigZSTLak0VzF5yC05WSSIjt3WV?= =?Windows-1252?Q?ymcHlWFPZDy17+rNPtR4id4On+MDm37jXifsdS6D8Afg/0XBTSTZsilU?= =?Windows-1252?Q?HtgTKFd63JYS1qKNBZfDNtCCGENlRzG9b3vzebaJaeuDuC+erYi3CQfV?= =?Windows-1252?Q?QFv51xZwqJyeNmg6O5/DNfJ7nduVlEUWkQpi9W6izXkokCqgYVHA/bS/?= =?Windows-1252?Q?yhIqRb3ojtLDkcKeIYxLcnrIeo0tAmYSss12iH3qyF6AWHsp0c8UTFXz?= =?Windows-1252?Q?GxSMkW9xROfNKXhvFw+VsIGjS3/Aa3SSsbTx7WzvydSZz68TKftdpiyE?= =?Windows-1252?Q?2Vakms7whAu0PF15NvPDCMR4ORTSuk3uRhYVZnhicz/4I38AjCl6lY28?= =?Windows-1252?Q?vAXJnHb/4qo1b8eYk3jlyspfQktVKfIVqmHRCtJAeBcZRvVr178rzPZj?= =?Windows-1252?Q?xg6kO2S4ED+VgQgRLXMYAeq8C5jDFK0TqHHaT0T7WNk443bF8XGbGRdW?= =?Windows-1252?Q?BMEEwaefP0xuPECIn8ILUvOhEClaTJr2hTf++SbIIEubK+Xu4lSWECyT?= =?Windows-1252?Q?n24q5jXzBBlnrjuIn+3HmecQHqQ8f/iDlsRSosQtkVXKjjxz2j8i3PQ3?= =?Windows-1252?Q?coDEKpDgtWVLN7Dj2xwZ7xkDxw37lRqueRdeYsiKhYyHL+lMDUD+ZNnf?= =?Windows-1252?Q?q7g3IC266PUQ4ZVjPFCFTUGSgw8RyUMOWNnmiwSdV1hMECRCTFqmZj+3?= =?Windows-1252?Q?wXjnfdavQYNlY1dsOa0sIstuuWU6JrJKo9N4vme65Wj6RKd6zOmkoRXm?= =?Windows-1252?Q?A1pLvWx3qQKyDfW1GCdYrn1nWz6Uw5/kRbSIP2HEwIiByeE+BDDYyLel?= =?Windows-1252?Q?MOM4OTW26r6a79NLvkD+j4NhWBuoc51f+KOqyBSCuzrcFLAqM70j7iIR?= =?Windows-1252?Q?U/qSLSs52S4?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:McVAZxHPZf9vdFwWFrPPruLkr0CTptkNp1/2UZ2kjLz9TTbFdH1vgbR3+hcEtwAZj8l5MeqqMwQ5Eq1WUVWtLqM9py7YfXZt8xV9u7dvxoSf40Sz3oImNwl8aiA3qUSt/tZAqsRfmRCfKbkcawhk9k55EmmUpo3jUutbSdiA4HJjoZIESo80LAy1ziE0bzj35lOJtmXUmZtuOLy5xtLUNfWUBaMeFunzunapgnV6LJUFJRkhSqb9ey06x+J3Q3HGUASkn9fkvJQ3j1yo3mI7KEhu6kNv7aLXxYtbU3KreKw=;5:dGyCDilFQZINuu9gNFXavf1N5CB66ksYud4g38cALDd1romIthB3+AI+IX9PY/H823NZdMAGRyP5Anwhspub2F18mWfWXL/TRoCmMf7yt37Ea67ZJu9bsJROeF9gKXNkmkTeAcooYFDqzaWS6dI3gA==;24:lbu+s/IyAAJJsAYmxX5GPLb4TIap8xwDwxla/AAAMcC5sGHfHaSgWbamjxkiy5ELPTMW0y3k1jrFAL6qAI+rQL0JxYJYp/Lx7a8/zKt0RU4=;7:5DQ/cenNQsjX9NQn+NHkJMC0vUzY8mkQqNYG9r2iryDutVfNvkgYoedSiPj/dfO/bpglbkfOaMN/xRX5zMv4LtrHmn00ba01wiaSOthAj5IYG1inyRLcmS95NHwMipFwb+7yr4H0/LR2hoZJAX+SqsvpA2KSCM+cY2zvysXw+W/I2fZlrX+ar0yJyTeQOUS6Fc0dXdCJNyuBb0bLu4Ok+3RJ8YtVTG7B4jVFTsInGsKOYI4BLC6yJ975sW7tWTXU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:Bxd10RQ43Iw2viPJWF8cYyjY13L6rzT89yA+I01KpP8pv6LCtj859BocGyfoCPm3eYE6QQ+r05JGXUPz8vHI5tm7Cj1AMvEmVGEwZPTEMuxHPhz0zLHD3HXPNbPnE/Yv93nwsW3kKA2swwr04HR6rD9JWbj8QMd+xijvU//Rmlg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 18:51:53.7596 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-01_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 12:05 PM, Omar Sandoval wrote: >> diff --git a/lib/Kconfig b/lib/Kconfig >> index d79909dc01ec..5a65a1f91889 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -550,4 +550,8 @@ config STACKDEPOT >> bool >> select STACKTRACE >> >> +config WBT >> + bool >> + select SCALE_BITMAP > > Looks like this snuck in from your experiments to get this to work on > top of scale_bitmap? Oops yes, it is indeed. Killed, thanks. >> + if (waitqueue_active(&rwb->wait)) { >> + int diff = limit - inflight; >> + >> + if (!inflight || diff >= rwb->wb_background / 2) >> + wake_up_nr(&rwb->wait, 1); > > wake_up(&rwb->wait)? Yeah, that'd be cleaner. I think this is a leftover from when I experimented with batched wakeups, with nr != 1. I'll change it to just wake_up(). -- Jens Axboe