From: Krzysztof Kozlowski <krzk@kernel.org>
To: Irui Wang <irui.wang@mediatek.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
angelogioacchino.delregno@collabora.com,
nicolas.dufresne@collabora.com, wenst@chromium.org,
kyrie wu <kyrie.wu@mediatek.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Tomasz Figa <tfiga@chromium.org>,
xia.jiang@mediatek.com, maoguang.meng@mediatek.com,
Rob Herring <robh@kernel.org>
Subject: Re: [V15,01/15] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible
Date: Mon, 26 Sep 2022 16:07:05 +0200 [thread overview]
Message-ID: <b9874b8f-b40f-f48d-856a-c5fc91384042@kernel.org> (raw)
In-Reply-To: <20220926091433.18633-2-irui.wang@mediatek.com>
On 26/09/2022 11:14, Irui Wang wrote:
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/memory/mt8195-memory-port.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + jpgenc-master {
> + compatible = "mediatek,mt8195-jpgenc";
Use 4 spaces for example indentation. You have it quite inconsistent.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-26 15:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 9:14 [V15,0/15] Enable jpeg enc & dec multi-hardwares for MT8195 Irui Wang
2022-09-26 9:14 ` [V15,01/15] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible Irui Wang
2022-09-26 14:07 ` Krzysztof Kozlowski [this message]
2022-09-26 9:14 ` [V15,02/15] mtk-jpegenc: export jpeg encoder functions Irui Wang
2022-09-26 9:14 ` [V15,03/15] mtk-jpegenc: support jpegenc multi-hardware Irui Wang
2022-09-26 9:14 ` [V15,04/15] mtk-jpegenc: add jpegenc timeout func interface Irui Wang
2022-09-26 9:14 ` [V15,05/15] mtk-jpegenc: add jpeg encode worker interface Irui Wang
2022-09-26 9:14 ` [V15,06/15] mtk-jpegenc: add output pic reorder interface Irui Wang
2022-09-26 9:14 ` [V15,07/15] mtk-jpegenc: add stop cmd interface for jpgenc Irui Wang
2022-09-26 9:14 ` [V15,08/15] dt-bindings: mediatek: Add mediatek,mt8195-jpgdec compatible Irui Wang
2022-09-26 14:07 ` Krzysztof Kozlowski
2022-09-26 9:14 ` [V15,09/15] media: mtk-jpegdec: export jpeg decoder functions Irui Wang
2022-09-26 9:14 ` [V15,10/15] media: mtk-jpegdec: support jpegdec multi-hardware Irui Wang
2022-09-26 9:14 ` [V15,11/15] media: mtk-jpegdec: add jpegdec timeout func interface Irui Wang
2022-09-26 9:14 ` [V15,12/15] media: mtk-jpegdec: add jpeg decode worker interface Irui Wang
2022-09-26 9:14 ` [V15,13/15] media: mtk-jpegdec: add output pic reorder interface Irui Wang
2022-09-26 9:14 ` [V15,14/15] media: mtk-jpegdec: refactor jpegdec func interface Irui Wang
2022-09-26 9:14 ` [V15,15/15] mtk-jpegdec: add stop cmd interface for jpgdec Irui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9874b8f-b40f-f48d-856a-c5fc91384042@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kyrie.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tfiga@chromium.org \
--cc=tzungbi@chromium.org \
--cc=wenst@chromium.org \
--cc=xia.jiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).