linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: David Miller <davem@davemloft.net>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	keescook@chromium.org
Subject: Re: [PATCH net-next] rxrpc: Mark expected switch fall-through
Date: Thu, 4 Apr 2019 10:31:08 -0500	[thread overview]
Message-ID: <b98b16a9-010b-939f-405b-29dabef404b9@embeddedor.com> (raw)
In-Reply-To: <20190403.213907.2080789345265344655.davem@davemloft.net>



On 4/3/19 11:39 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 1 Apr 2019 14:39:31 -0500
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:
>> net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (ret < 0) {
>>       ^
>> net/rxrpc/local_object.c:184:2: note: here
>>   case AF_INET:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Currently, GCC is expecting to find the fall-through annotations
>> at the very bottom of the case and on its own line. That's why
>> I had to add the annotation, although the intentional fall-through
>> is already mentioned in a few lines above.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Applied.
> 

Thanks, Dave.

--
Gustavo

  reply	other threads:[~2019-04-04 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 19:39 [PATCH net-next] rxrpc: Mark expected switch fall-through Gustavo A. R. Silva
2019-04-04  4:39 ` David Miller
2019-04-04 15:31   ` Gustavo A. R. Silva [this message]
2019-04-05 15:15 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b98b16a9-010b-939f-405b-29dabef404b9@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).