From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2A50C432BE for ; Thu, 29 Jul 2021 15:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D5B560F21 for ; Thu, 29 Jul 2021 15:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238070AbhG2Pzb (ORCPT ); Thu, 29 Jul 2021 11:55:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237851AbhG2Pz3 (ORCPT ); Thu, 29 Jul 2021 11:55:29 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7690EC061765; Thu, 29 Jul 2021 08:55:25 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id u25so9005176oiv.5; Thu, 29 Jul 2021 08:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TV3s+6Ek9QNCMB+l3h/81KjOffdCml0U1KqwweGRv3M=; b=W3qmxYqU0FFMIiEndRoCpJYEarj9iL17Qe7ByS+YdVWNkwvbtvXREX8s9c/GmtnlLP saZpa5ulXRgF9yzHmUx2dwIrOfqU/nFOsn2iHVHe5lFJePtbTc3meLDC+ama3Fbjg0DE MYqSSBDEbTImMeNqshH0XSzTGmeSTPx70YmOXmO1gGA+fa18YGOXhtMm/Xz0/Ov8zeJN NB1jWH968HqaG6VZvwtz28OD7/3DS8vAn92RTP4T48JqjkGMhPcrGvAi6rr9bgjBhNUl eaccPi9gIM1z28VT5y+OSDQgY4/VCmJbZ2xPpH6UrRM9E4AsoNKVb0kNkeAkbZ4hTTrV Tjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TV3s+6Ek9QNCMB+l3h/81KjOffdCml0U1KqwweGRv3M=; b=FMqoGQtBuwEwuXIWg6P08raBxtXXWNqp3VRxLJ/6rhWmegmvDABKZJAylOk7g0gfqI rZGhubFmizHb/gyy98B37a1u7IlWKrPYwBcMxqKJyzZzt7y5139otJcHsRfDMcjWwK2I AhKdmtr9HfIlNwiqheagifQBF7t3prQ7fIfUmJ5eHepTYOE9NnsICWmrUom2YXI+9RVE 4u90Hqs/tcNHoDh71l3f2dRs4s9CSKCwKiYUYreZGPAGRAVpi9j+8W2jAjtper710OLM VuNOIoWLbdMvy1+Hy/66dk0s7pJ1byuWcgn/4X7eZqWFsgRGncUrpwyLyk37V29uBbz1 KHbw== X-Gm-Message-State: AOAM532ttkLrQ/EB7m0FT2PIWe/cG9u+0MjCEKS0Nn/qKsr40Th2T6jA DmD5XsBzr6rGB3AoZmECg++7ge2Vi9jPG1Kz X-Google-Smtp-Source: ABdhPJw+lDVr0eHFBVHNYdcQZ/0qtg70dFXQ9vTVwaLB6U8P5GaqHrNFJ7JH7FtQT5eCOpu1YrDzcQ== X-Received: by 2002:a05:6808:144a:: with SMTP id x10mr3598431oiv.82.1627574124908; Thu, 29 Jul 2021 08:55:24 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id q187sm681208oif.2.2021.07.29.08.55.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 08:55:24 -0700 (PDT) Subject: Re: [RFC PATCH 2/8] block: Add block device LED trigger list To: =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org, axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org References: <20210729015344.3366750-1-arequipeno@gmail.com> <20210729015344.3366750-3-arequipeno@gmail.com> <108872.1627528448@turing-police> From: Ian Pilcher Message-ID: Date: Thu, 29 Jul 2021 10:55:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <108872.1627528448@turing-police> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/21 10:14 PM, Valdis Klētnieks wrote: > Is this bisect-clean (as in "will it build properly with that config option > set after each of the succeeding patches")? Usually, the config option > is added in the *last* patch, so that even if you have a bisect issue > it won't manifest because it's wrapped in a '#ifdef CONFIG_WHATEVER' > that can't possibly be compiled in because there's no way for Kconfig > to set that variable. Yes it is. I tested compiling each patch with the CONFIG option both enabled and disabled. (You will get an unused function warning for blk_ledtrig_find() until patch #3 is applied.) I'll switch to adding the option in the last patch of the series in the future. Thanks! -- ======================================================================== In Soviet Russia, Google searches you! ========================================================================