From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC69C433F5 for ; Fri, 19 Nov 2021 06:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A117061154 for ; Fri, 19 Nov 2021 06:32:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbhKSGf4 (ORCPT ); Fri, 19 Nov 2021 01:35:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhKSGfy (ORCPT ); Fri, 19 Nov 2021 01:35:54 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5580DC06173E for ; Thu, 18 Nov 2021 22:32:53 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id gt5so7189755pjb.1 for ; Thu, 18 Nov 2021 22:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=accesio-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pitqVTnR52sCvxpnb0+Tu14MFJWNMqrMhYyHvSknELA=; b=xz3H6UmTjG0kI/uDX9MZflaKyd9H1dTdKXv3Yyb44XFzwDLc98A1WXNgSXd1NEjTZu +3K/7hU6SK/+wYJ4dMIl14LrIFYtcGL5q4d+qDkyagN4vb5Zp6ZPh40BjExTxgz6nts4 K2A6TfaWw8FPnASm/4JhITJLb3cD7r22BijeCUxt9INV1yggI54hsX8snXO0GGvI5+PM HsvkKvy5d4C9Oif/WYUnTKlN6cYB/GhHMLBgBk4I2LkwjxPbH41xnFXezn68hjDKZCJy STKCToI6NEyP9DhfLwxV+lxVhDP8fMh3r3wKLKupgd5M00wrfzdqeCSDHtLZqxOSH4EI 4oTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pitqVTnR52sCvxpnb0+Tu14MFJWNMqrMhYyHvSknELA=; b=hjNXVPF0TAYBk2mJqPR907bslXwc2PNIspi0krCV5Y2ABWIeHRrlSa2qbYnnr9nOYA r+0lrus1CMCfyUspgsa2HxridpYfSO20NYbG7/EyoT5pLZRPC26O+UCtn+TVXfGE0R/N lWYQf5Sq3PyCNTxzL0DN/at1XXSqOX17s933WStu7z7sDR0YupQfDvPuMoYyvoFryTEl TVWQI7STcJfmKacLscS2VLl71/HOEEiIeGClUL8GAn5kZRMtb+p7qqRQ2JJ5xY59mB2G TU4sMxtm83VxeXn+lcCE49ilh5gKtM4Rr8zETMB+QO5WlJE7zuhnZQzl2EC2w3RRKbtw HjJw== X-Gm-Message-State: AOAM532AYIOpV25BMHTwpsPoXRFClVPjc6ZyvMa9yaBtdIceuZtKba0o DhVS/2eYjlD9T81xCVD58dEh X-Google-Smtp-Source: ABdhPJytghvkGiCOGjcJVx6q7f8229wvM4d8skJfb4j1wJr7PoZsOIpWZJHI83dI0UzwgXMVAgSzJA== X-Received: by 2002:a17:90b:17cc:: with SMTP id me12mr1787160pjb.179.1637303572868; Thu, 18 Nov 2021 22:32:52 -0800 (PST) Received: from [172.16.8.241] ([98.149.220.160]) by smtp.gmail.com with ESMTPSA id h18sm1667272pfh.172.2021.11.18.22.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Nov 2021 22:32:52 -0800 (PST) Subject: Re: [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby References: <20211117145750.43911-1-andriy.shevchenko@linux.intel.com> From: Jay Dolan Message-ID: Date: Thu, 18 Nov 2021 22:32:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211117145750.43911-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/21 6:57 AM, Andy Shevchenko wrote: > Split Pericom driver to a separate module. > While at it, re-enable high baud rates. > > Jay, can you, please, test this on as many hardware as you have? > > The series depends on the fix-series: https://lore.kernel.org/linux-serial/20211117145502.43645-1-andriy.shevchenko@linux.intel.com/T/#u > > Andy Shevchenko (1): > serial: 8250_pci: Split out Pericom driver > > Jay Dolan (1): > serial: 8250_pericom: Re-enable higher baud rates > > drivers/tty/serial/8250/8250_pci.c | 405 +------------------------ > drivers/tty/serial/8250/8250_pericom.c | 217 +++++++++++++ > drivers/tty/serial/8250/Kconfig | 8 + > drivers/tty/serial/8250/Makefile | 1 + > 4 files changed, 231 insertions(+), 400 deletions(-) > create mode 100644 drivers/tty/serial/8250/8250_pericom.c > I have my current state here: https://github.com/accesio/linux/blob/split-pericom-driver/drivers/tty/serial/8250/8250_pericom.c * Change port type to UPIO_PORT * Add in pericom_do_startup() because the UPF_MAGIC_MULTIPLIER doesn't stick. When I'm testing baud rates greater than baud_base I'm seeing strange things on the scope. Maybe I'm just tired, and it's human error. I should be able to get back to it and get it done on Saturday.