From: Benjamin GAIGNARD <benjamin.gaignard@st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"kgene@kernel.org" <kgene@kernel.org>,
"hminas@synopsys.com" <hminas@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
Amelie DELAUNAY <amelie.delaunay@st.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to json-schema
Date: Thu, 2 Jan 2020 08:43:40 +0000 [thread overview]
Message-ID: <b9b1b18f-b331-de6a-1622-ad43143eb56f@st.com> (raw)
In-Reply-To: <20191230153524.GA4918@pi3>
On 12/30/19 4:35 PM, Krzysztof Kozlowski wrote:
> On Thu, Dec 19, 2019 at 11:35:35AM +0100, Benjamin Gaignard wrote:
>> Convert DWC2 bindings to DT schema format using json-schema.
>> DWC2 is widely use but a couple of compatibles and properties
>> (vusb_d-supply,vusb_a-supply) were missing in dwc2.txt, the
>> patch add them.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>> ---
>> CC: Minas Harutyunyan <hminas@synopsys.com>
>>
>> changes in version 2:
>> - put Minas Harutyunyan <hminas@synopsys.com> as maintainer
>> - remove type and description from phy property
>> - remove description from compatible items
>> - simplify samsung,s3c6400-hsotg compatible handling
>>
> (...)
>
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - clocks
>> + - clock-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + usb@101c0000 {
>> + compatible = "ralink,rt3050-usb, snps,dwc2";
> Does it pass dtbs_check? Should be two strings.
Bad copy/past from the original text file.
You are right it should two strings and dt check tools don't detect
because they see it as a different compatible.
Benjamin
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2020-01-02 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:35 [PATCH v2 0/2] Add yaml DWC2 bindings Benjamin Gaignard
2019-12-19 10:35 ` [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to json-schema Benjamin Gaignard
2019-12-30 15:35 ` Krzysztof Kozlowski
2020-01-02 8:43 ` Benjamin GAIGNARD [this message]
2019-12-19 10:35 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node Benjamin Gaignard
2019-12-30 15:37 ` Krzysztof Kozlowski
2020-01-02 8:50 ` Benjamin GAIGNARD
2020-01-03 11:16 ` Krzysztof Kozlowski
2019-12-19 12:54 ` [PATCH v2 0/2] Add yaml DWC2 bindings Minas Harutyunyan
2019-12-20 22:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b1b18f-b331-de6a-1622-ad43143eb56f@st.com \
--to=benjamin.gaignard@st.com \
--cc=amelie.delaunay@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).