From: Randy Dunlap <rdunlap@infradead.org>
To: Li Zhengyu <lizhengyu3@huawei.com>, palmer@rivosinc.com
Cc: paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
liaochang1@huawei.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
kexec@lists.infradead.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] RISCV: kexec: Fix build error without CONFIG_MODULES
Date: Wed, 1 Jun 2022 09:08:16 -0700 [thread overview]
Message-ID: <b9c831a3-44ab-0374-34f8-8bd8bc311e5c@infradead.org> (raw)
In-Reply-To: <20220601063924.13037-1-lizhengyu3@huawei.com>
Hi--
On 5/31/22 23:39, Li Zhengyu wrote:
> When CONFIG_MODULES is not set/enabled:
>
> ../arch/riscv/kernel/elf_kexec.c:353:9: error: unknown type name 'Elf_Rela'; did you mean 'Elf64_Rela'?
> 353 | Elf_Rela *relas;
> | ^~~~~~~~
> | Elf64_Rela
>
> Replace Elf_Rela by Elf64_Rela to avoid relying on CONFIG_MODULES.
>
BTW, does this mean that RISC-V kexec is only available on 64BIT
and not on 32BIT?
thanks.
> Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com>
> ---
> arch/riscv/kernel/elf_kexec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
> index 9cb85095fd45..0cb94992c15b 100644
> --- a/arch/riscv/kernel/elf_kexec.c
> +++ b/arch/riscv/kernel/elf_kexec.c
> @@ -349,7 +349,7 @@ int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
> {
> const char *strtab, *name, *shstrtab;
> const Elf_Shdr *sechdrs;
> - Elf_Rela *relas;
> + Elf64_Rela *relas;
> int i, r_type;
>
> /* String & section header string table */
--
~Randy
next prev parent reply other threads:[~2022-06-01 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 6:39 [PATCH] RISCV: kexec: Fix build error without CONFIG_MODULES Li Zhengyu
2022-06-01 15:59 ` Randy Dunlap
2022-06-01 16:08 ` Randy Dunlap [this message]
2022-06-02 1:02 ` lizhengyu (E)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9c831a3-44ab-0374-34f8-8bd8bc311e5c@infradead.org \
--to=rdunlap@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lizhengyu3@huawei.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).