From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895Ab0AHHEL (ORCPT ); Fri, 8 Jan 2010 02:04:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751208Ab0AHHEK (ORCPT ); Fri, 8 Jan 2010 02:04:10 -0500 Received: from mail-pz0-f188.google.com ([209.85.222.188]:55264 "EHLO mail-pz0-f188.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150Ab0AHHEJ (ORCPT ); Fri, 8 Jan 2010 02:04:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=O5tszVHCIRBXx2Lhmi+8V6gL/fceUHHnKjUbusJJ4GHqr6aMiOVrpTVIg5ZSgS0D7L RUEkbYL23pJMQrVMDRtiznC2422oFNbOpqZ86jxFt30Rq3VLfqyO+mF8jIukRi0pSBgA HEJAmE3UQwWmImpJIEy30zDsDTos0gMVfli6M= MIME-Version: 1.0 In-Reply-To: <20100107145126.22271109.akpm@linux-foundation.org> References: <20100107145126.22271109.akpm@linux-foundation.org> Date: Fri, 8 Jan 2010 13:04:05 +0600 Message-ID: Subject: Re: [PATCH] acpi: Fix unused variable warning in sbs.c From: Rakib Mullick To: Andrew Morton Cc: LKML , Len Brown , Alexey Starikovskiy Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/8/10, Andrew Morton wrote: > > I wonder if it can be fixed in Kconfig. Is there any sane use of > this code when CONFIG_ACPI_SYSFS_POWER=n && CONFIG_ACPI_PROCFS_POWER=n? > No. Making it depend on CONFIG_ACPI_SYSFS_POWER || CONFIG_ACPI_PROCFS_POWER, doesn't make sense too. What about wrapping around acpi_battery_remove with #ifdef from it's calling point.