From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161890AbdD0FTv (ORCPT ); Thu, 27 Apr 2017 01:19:51 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37613 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161849AbdD0FTk (ORCPT ); Thu, 27 Apr 2017 01:19:40 -0400 Subject: Re: [PATCH 3/3] iio: tools: generic_buffer: increase trigger length To: Eugen Hristev , nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org, lars@metafoo.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ludovic.desroches@microchip.com References: <1492590045-17329-1-git-send-email-eugen.hristev@microchip.com> <1492590045-17329-4-git-send-email-eugen.hristev@microchip.com> From: Jonathan Cameron Message-ID: Date: Thu, 27 Apr 2017 06:19:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <1492590045-17329-4-git-send-email-eugen.hristev@microchip.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GH Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/17 09:20, Eugen Hristev wrote: > Increased trigger length to 50 in order to cope with trigger names like > fc030000.adc-dev0-external-rising > > Signed-off-by: Eugen Hristev This is fine (though I'd go bigger as Daniel suggested) I'll pick it up with the revised series. thanks, Jonathan > --- > tools/iio/iio_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/iio/iio_utils.h b/tools/iio/iio_utils.h > index 780f201..9d59771 100644 > --- a/tools/iio/iio_utils.h > +++ b/tools/iio/iio_utils.h > @@ -13,7 +13,7 @@ > #include > > /* Made up value to limit allocation sizes */ > -#define IIO_MAX_NAME_LENGTH 30 > +#define IIO_MAX_NAME_LENGTH 50 > > #define FORMAT_SCAN_ELEMENTS_DIR "%s/scan_elements" > #define FORMAT_TYPE_FILE "%s_type" >