From: Vladimir Barinov <v.barinov@yadro.com>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux@yadro.com>,
<linux-leds@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/2] dt-bindings: leds: Document Awinic AW2016 bindings
Date: Fri, 2 Jun 2023 11:46:36 +0300 [thread overview]
Message-ID: <b9fc06dd-d9e4-58fc-6252-87590c416ce7@yadro.com> (raw)
In-Reply-To: <20230602080655.GN449117@google.com>
Hi Lee,
On 6/2/23 11:06, Lee Jones wrote:
> «Внимание! Данное письмо от внешнего адресата!»
>
> On Wed, 24 May 2023, Rob Herring wrote:
>
>> On Wed, 24 May 2023 14:40:56 +0300, Vladimir Barinov wrote:
>>> Add Awinic AW2026 binding documentation
>>>
>>> Signed-off-by: Vladimir Barinov <v.barinov@yadro.com>
>>> ---
>>> .../bindings/leds/awinic,aw2026.yaml | 92 +++++++++++++++++++
>>> 1 file changed, 92 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/leds/awinic,aw2026.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error: Documentation/devicetree/bindings/leds/awinic,aw2026.example.dts:52.3-53.1 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/leds/awinic,aw2026.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
> Taking this set out of my review queue until this is rectified.
Thank you for paying attention for this commit.
I've already resent fixes in v2 version:
https://lore.kernel.org/all/20230525101341.2036563-1-v.barinov@yadro.com/
>
> --
> Lee Jones [李琼斯]
--
Regards
Vladimir
prev parent reply other threads:[~2023-06-02 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 11:39 [PATCH 0/2] leds: add Awinic AW2016 driver Vladimir Barinov
2023-05-24 11:40 ` [PATCH 1/2] leds: add Awinic AW2016 LED driver Vladimir Barinov
2023-05-24 11:40 ` [PATCH 2/2] dt-bindings: leds: Document Awinic AW2016 bindings Vladimir Barinov
2023-05-24 12:21 ` Rob Herring
2023-06-02 8:06 ` Lee Jones
2023-06-02 8:46 ` Vladimir Barinov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9fc06dd-d9e4-58fc-6252-87590c416ce7@yadro.com \
--to=v.barinov@yadro.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@yadro.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).