linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Krzysztof Opasiak <k.opasiak@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 2/2] usbip: use monotonic timestamps
Date: Tue, 7 Nov 2017 14:10:57 -0700	[thread overview]
Message-ID: <ba0a6828-1fe7-636d-ce48-61cc0f38e9a2@kernel.org> (raw)
In-Reply-To: <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com>

On 11/07/2017 04:22 AM, Krzysztof Opasiak wrote:
> 
> 
> On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
>> This gets rid of the deprecated do_gettimeofday() function in usbip.
>> The comment above vgadget_get_frame() mentions that it suffers
>> from issues with the time jumps due to suspend and settimeofday,
>> so I'm changing it to use ktime_get_ts64() to use monotonic times
>> that don't have this problem.
>>
>> I couldn't tell whether we should use CLOCK_MONOTONIC or
>> CLOCK_MONOTONIC_RAW here, the difference being the exact rate
>> when correcting for NTP. I picked monotonic time since it doesn't
>> change the speed to the existing code and should be better
>> synchronized with other machines we talk to.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks good to me:
> Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
> 

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

  reply	other threads:[~2017-11-07 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171107104018epcas5p1f9c72d541c679e1c5a44e03a901e8498@epcas5p1.samsung.com>
2017-11-07 10:39 ` [PATCH 1/2] usbip: fix off-by-one frame number calculation Arnd Bergmann
2017-11-07 10:39   ` [PATCH 2/2] usbip: use monotonic timestamps Arnd Bergmann
2017-11-07 11:22     ` Krzysztof Opasiak
2017-11-07 21:10       ` Shuah Khan [this message]
2017-11-07 11:21   ` [PATCH 1/2] usbip: fix off-by-one frame number calculation Krzysztof Opasiak
2017-11-07 21:10     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba0a6828-1fe7-636d-ce48-61cc0f38e9a2@kernel.org \
    --to=shuah@kernel.org \
    --cc=arnd@arndb.de \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=k.opasiak@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).