From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@codeaurora.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask
Date: Mon, 5 Sep 2016 20:34:08 +0200 [thread overview]
Message-ID: <ba2307b6-e139-0dfb-94c1-ea69548868b4@broadcom.com> (raw)
In-Reply-To: <6123998.NAlOfyAp5F@wuerfel>
On 5-9-2016 17:26, Arnd Bergmann wrote:
> On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
>> Arnd Bergmann <arnd@arndb.de> wrote:
>>> While fixing another bug, I noticed that bcma manually sets up
>>> a dma_mask pointer for its child devices. We have a generic
>>> helper for that now, which should be able to cope better with
>>> any variations that might be needed to deal with cache coherency,
>>> unusual DMA address offsets, iommus, or limited DMA masks, none
>>> of which are currently handled here.
>>>
>>> This changes the core to use the of_dma_configure(), like
>>> we do for platform devices that are probed directly from
>>> DT.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Nobody tested this, so I'll drop the patch.
>>
>
> Should I resend it? I think it's still required.
Maybe you should request some bcma users (Rafał?) explicitly to test
this. I have no equipment with CONFIG_OF enabled over here.
Regards,
Arend
next prev parent reply other threads:[~2016-09-05 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160903140819.245F06216C@smtp.codeaurora.org>
2016-09-05 15:26 ` [v2] bcma: use of_dma_configure() to set initial dma mask Arnd Bergmann
2016-09-05 18:34 ` Arend Van Spriel [this message]
2016-09-06 7:48 ` Kalle Valo
2016-03-17 9:39 [PATCH v2] " Arnd Bergmann
2016-09-03 14:08 ` [v2] " Kalle Valo
2016-09-09 9:03 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba2307b6-e139-0dfb-94c1-ea69548868b4@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arnd@arndb.de \
--cc=hauke@hauke-m.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).