From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B55C352BE for ; Fri, 17 Apr 2020 12:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBF7221D94 for ; Fri, 17 Apr 2020 12:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="lEkRi338" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbgDQMdN (ORCPT ); Fri, 17 Apr 2020 08:33:13 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:46091 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727877AbgDQMdM (ORCPT ); Fri, 17 Apr 2020 08:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1587126791; x=1618662791; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=KoXqWzqYq/w2d+HZn8byhgpTiDLf6r5C2Ybuny75IaM=; b=lEkRi338fpxiPrzC9aJzRjUyPBe7RecCPnaXou8o50KgDn+7o+3uM+0G WSwSeQwyXW+AszRtYdQjG5Iny+kM6zIy40CwydmikGvFy2ljmdc+poBMT gp4XRrMfDGNtcdYpTRhInq2pHfG0VcKYtI50rqDEODEae9um0Valbo5cC wU+uB4SYniFp/DSGFOseJkkdY3lO+Qk8jv2GFIcZfcheV6nbl7gwn5KsV DAJ2las9SXssP+ruEbrWP1AY+Q67TogET2zY2VfnEgIQct9pOXKvZ1LZq kvhoeKwxSm88+skr6Kq8umRfYNKOozQZZX5Uisbo1yPzcgey8kHvwZFYZ A==; IronPort-SDR: gWqIczFLyA96iDGpH5JnlYbjBaosq3zeGhSGMYW1MpmLw6wBaKd/m5lzsnC5A5lxqflsMkBCcl iK3RqGgR+ZruiKh3p0qZfV+wvJTGOrxpeOi9iag8qESRYzg2gs/CxlvksC7ml19M6F1iGRXOpa nd+76P8dKowiZQG9+x5WTbDs5pggHwxnCKqxAVlqgnhIbOPr3JYqNOI0fYG9beh4qv/8dkYCkD COoII3vOvnVHdONyprH1PlugE6r8DyEwdj1OSQ1yPjbWyp62/+406rTyTtTNE1tsmvbEtnvmp8 eNc= X-IronPort-AV: E=Sophos;i="5.72,395,1580799600"; d="scan'208";a="9534003" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Apr 2020 05:33:10 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 17 Apr 2020 05:33:10 -0700 Received: from [10.205.29.56] (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Fri, 17 Apr 2020 05:32:45 -0700 Subject: Re: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines To: Harini Katakam , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , Claudiu Beznea CC: "linux-kernel@vger.kernel.org" , "David S. Miller" , Alexandre Belloni , "pthombar@cadence.com" , "sergio.prado@e-labworks.com" , "antoine.tenart@bootlin.com" , "f.fainelli@gmail.com" , "linux@armlinux.org.uk" , "andrew@lunn.ch" , Michal Simek , Rafal Ozieblo References: From: Nicolas Ferre Organization: microchip Message-ID: Date: Fri, 17 Apr 2020 14:33:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2020 at 20:26, Harini Katakam wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Nicolas, > >> -----Original Message----- >> From: nicolas.ferre@microchip.com [mailto:nicolas.ferre@microchip.com] >> Sent: Thursday, April 16, 2020 11:14 PM >> To: linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; Claudiu >> Beznea ; Harini Katakam >> >> Cc: linux-kernel@vger.kernel.org; David S. Miller ; >> Alexandre Belloni ; pthombar@cadence.com; >> sergio.prado@e-labworks.com; antoine.tenart@bootlin.com; >> f.fainelli@gmail.com; linux@armlinux.org.uk; andrew@lunn.ch; Michal Simek >> ; Nicolas Ferre ; Rafal >> Ozieblo >> Subject: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume >> routines >> >> From: Nicolas Ferre >> >> Use the proper struct device pointer to check if the wakeup flag and wakeup >> source are positioned. >> Use the one passed by function call which is equivalent to &bp->dev- >>> dev.parent. >> >> It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan >> feature is used. > > Sorry I have some mail issues; meant to reply earlier. > Tested patches 1, 2, 3 in this set and they work for me. Brilliant! Thanks for the feedback. > I'll try patch 4; it looks similar to what I'm using locally but I'll add whatever > tie-off queue handling is required on top of your series, thanks. Alright, I'll hold my v2 for a few days then. Thanks. Best regards, Nicolas -- Nicolas Ferre