From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4C8C47095 for ; Sun, 4 Oct 2020 21:13:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA098206DD for ; Sun, 4 Oct 2020 21:13:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AIi6XBnR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726570AbgJDVN5 (ORCPT ); Sun, 4 Oct 2020 17:13:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56666 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbgJDVN5 (ORCPT ); Sun, 4 Oct 2020 17:13:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601846036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5g8z6S2B6j+xxiFBjjsrhfdJC7yATVO13gI0yfLlEc=; b=AIi6XBnRwfxR++z3fsbDK4bGoimd1sVwR+S4RGHGiloiu1K8KDyaYVbY7/z3yIvKE0smYu f9ulAOWFuwMLZMtMeWxDEq9Tx3jGH1P0yoku4OY7umCCft1DV6qOTAeMuerXpyHhydqtEg 7m+n8LEat/2NVKj1q84XN7X2ZWFd5sw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-Ie-28906PPGY3yH2vSXXBw-1; Sun, 04 Oct 2020 17:13:54 -0400 X-MC-Unique: Ie-28906PPGY3yH2vSXXBw-1 Received: by mail-qv1-f72.google.com with SMTP id v14so4599643qvq.10 for ; Sun, 04 Oct 2020 14:13:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=D5g8z6S2B6j+xxiFBjjsrhfdJC7yATVO13gI0yfLlEc=; b=mDL1LhRyx5eF0EB7p1mkXi5o5gqA/8upY+P2t8yQsX5DYaNs3io6Hp4nugI8lDEhsr cH490oWbZvfGSvYVhkvL2GKiQhqCrFS7qiWHvHU9VQ+ZXJYooONOd4Ic8HRA0arZAX1+ 8Cm+QCOK7L6DqLUkdfEeg1vStkBpFNrdpHBt3GQpGD6kXyAzP+sYGLR3EJkzIB3EHASh n/mFj+To5T34EMhqvUEzhiaaA7O/92m9illXYcR+XiZ0s0haHj45zzEHkUN7H6n/sE5A HfyaaIHReLy9MW9yh4G/hwpO6j3mkpmJsgNse41x8nRVh4DlvZgo4xesXQguwRp4hGTd c1Sg== X-Gm-Message-State: AOAM533TlLAErk7bUAIkX6drboChzBKUoxETl/IYNMNbpzpQGARTytHH 3mIlVzvlqwNU+v931Z4wFQpZ1fcJ08ohA4MjUOoYGhiJQSbh2mItozF2T3l0n/tgjcTkytubBW0 gNx1iaTf2VfHZDNAOG5WIQtQI X-Received: by 2002:a0c:8b02:: with SMTP id q2mr11889463qva.48.1601846033974; Sun, 04 Oct 2020 14:13:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBm/DNLaWx5TY+QXm8x86b1+eqf3lzpjMrjev3k2uVCPg0ICM6del+7XR+gIKDjzCzbdNIjg== X-Received: by 2002:a0c:8b02:: with SMTP id q2mr11889447qva.48.1601846033788; Sun, 04 Oct 2020 14:13:53 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id 12sm5779154qty.34.2020.10.04.14.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 14:13:53 -0700 (PDT) Subject: Re: [PATCH v2 6/7] fpga: sec-mgr: enable cancel of secure update To: Russ Weight , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com References: <20201002223701.1317-1-russell.h.weight@intel.com> <20201002223701.1317-7-russell.h.weight@intel.com> From: Tom Rix Message-ID: Date: Sun, 4 Oct 2020 14:13:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201002223701.1317-7-russell.h.weight@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/20 3:37 PM, Russ Weight wrote: > Extend the Intel Security Manager class driver to include > an update/cancel sysfs file that can be written to request > that an update be canceled. The write may return EBUSY if > the update has progressed to the point that it cannot be > canceled by software or ENODEV if there is no update in > progress. > > Signed-off-by: Russ Weight > --- > v2: > - Bumped documentation date and version > - Minor code cleanup per review comments > --- > .../ABI/testing/sysfs-class-ifpga-sec-mgr | 10 ++++ > drivers/fpga/ifpga-sec-mgr.c | 59 +++++++++++++++++-- > include/linux/fpga/ifpga-sec-mgr.h | 1 + > 3 files changed, 66 insertions(+), 4 deletions(-) This is 10/12 of the original patch set. Discussions covered most of my issues, the others are changed here. Reviewed-by: Tom Rix