From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
k.kozlowski@samsung.com, mturquette@baylibre.com,
robh+dt@kernel.org, linux@armlinux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
Date: Wed, 15 Jun 2016 11:27:47 -0400 [thread overview]
Message-ID: <ba35a3a4-91f9-a9d8-16c9-0cdd409da48d@osg.samsung.com> (raw)
In-Reply-To: <1466000018-16784-5-git-send-email-ldewangan@nvidia.com>
Hello Laxman,
On 06/15/2016 10:13 AM, Laxman Dewangan wrote:
> Maxim Max77620 has one 32KHz clock output and the clock HW
> IP used on this PMIC is same as what it is there in the MAX77686.
>
> Add clock driver support for MAX77620 on the MAX77686 driver.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@dowhile0.org>
> ---
> drivers/clk/Kconfig | 7 ++++---
> drivers/clk/clk-max77686.c | 16 ++++++++++++++++
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 6afad74..d75f4c5 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -32,10 +32,11 @@ config COMMON_CLK_WM831X
> source "drivers/clk/versatile/Kconfig"
>
> config COMMON_CLK_MAX77686
> - tristate "Clock driver for Maxim 77686/77802 MFD"
> - depends on MFD_MAX77686
> + tristate "Clock driver for Maxim 77686/77802/MAX77620 MFD"
> + depends on MFD_MAX77686 || MFD_MAX77620
> ---help---
> - This driver supports Maxim 77686/77802 crystal oscillator clock.
> + This driver supports Maxim 77686/77802/MAX77620 crystal oscillator
s/MAX77620/77620
Besides this minor nit, the patch looks good to me:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-06-15 15:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:13 [PATCH 0/5] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-15 14:13 ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-06-15 15:12 ` Javier Martinez Canillas
2016-06-15 15:35 ` kbuild test robot
2016-06-15 15:35 ` [PATCH] clk: max77686: fix semicolon.cocci warnings kbuild test robot
2016-06-16 9:31 ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Krzysztof Kozlowski
2016-06-16 13:02 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-15 15:19 ` Javier Martinez Canillas
2016-06-16 9:34 ` Krzysztof Kozlowski
2016-06-16 9:44 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-15 15:24 ` Javier Martinez Canillas
2016-06-16 9:49 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-06-15 15:27 ` Javier Martinez Canillas [this message]
2016-06-16 9:54 ` Krzysztof Kozlowski
2016-06-16 9:52 ` Laxman Dewangan
2016-06-16 10:11 ` Krzysztof Kozlowski
2016-06-16 13:02 ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan
2016-06-15 15:39 ` Javier Martinez Canillas
2016-06-16 12:25 ` Krzysztof Kozlowski
2016-06-16 13:06 ` Javier Martinez Canillas
2016-06-16 13:08 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba35a3a4-91f9-a9d8-16c9-0cdd409da48d@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).