From: Marek Vasut <marex@denx.de>
To: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: socfpga: use stdout-path for chosen node
Date: Wed, 8 Aug 2018 14:11:09 +0200 [thread overview]
Message-ID: <ba66504e-c002-7dc6-daed-633fee896131@denx.de> (raw)
In-Reply-To: <CAAh8qsyHxMjwBtBa5pYejkOxwFRbbFbt+myC4ynQQonK8MAo-w@mail.gmail.com>
On 08/08/2018 02:02 PM, Simon Goldschmidt wrote:
> On Wed, Aug 8, 2018 at 1:32 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 08/08/2018 11:09 AM, Simon Goldschmidt wrote:
>>> Use stdout-path dts property for kernel console.
>>>
>>> There were two socfpga boards left not using stdout-path:
>>> socrates and vining. Make sure they match the other boards.
>>>
>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>> ---
>>> arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 3 ++-
>>> arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 3 ++-
>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
>>> index 53bf99eef66d..6f5255a7d192 100644
>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
>>> @@ -22,7 +22,8 @@
>>> compatible = "ebv,socrates", "altr,socfpga-cyclone5", "altr,socfpga";
>>>
>>> chosen {
>>> - bootargs = "console=ttyS0,115200";
>>> + bootargs = "earlyprintk";
>>> + stdout-path = "serial0:115200n8";
>>> };
>>>
>>> memory@0 {
>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
>>> index f50b19447de6..e61efe16e79c 100644
>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
>>> @@ -54,7 +54,8 @@
>>> compatible = "samtec,vining", "altr,socfpga-cyclone5", "altr,socfpga";
>>>
>>> chosen {
>>> - bootargs = "console=ttyS0,115200";
>>> + bootargs = "earlyprintk";
>>
>> Why this earlyprintk ?
>
> The reason is Dinh added that to all socfpga boards in his commit [1]
> and I wanted the remaining two boards to be the same.
Isn't earlyprintk mostly a debugging aid ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-08-08 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 9:09 [PATCH] ARM: dts: socfpga: use stdout-path for chosen node Simon Goldschmidt
2018-08-08 10:00 ` Marek Vasut
2018-08-08 12:02 ` Simon Goldschmidt
2018-08-08 12:11 ` Marek Vasut [this message]
2018-09-05 7:54 ` Geert Uytterhoeven
2018-08-15 15:09 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba66504e-c002-7dc6-daed-633fee896131@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=simon.k.r.goldschmidt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).