From: John Garry <john.garry@huawei.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: <kevin.tian@intel.com>, <ashok.raj@intel.com>,
<linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>, <jacob.jun.pan@intel.com>,
Robin Murphy <robin.murphy@arm.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [RFC PATCH 0/4] iommu: Per-group default domain type
Date: Mon, 20 Jan 2020 09:44:51 +0000 [thread overview]
Message-ID: <ba7a7e6a-8b23-fca0-a8bb-72c4dbfa8390@huawei.com> (raw)
In-Reply-To: <20200101052648.14295-1-baolu.lu@linux.intel.com>
On 01/01/2020 05:26, Lu Baolu wrote:
> An IOMMU group represents the smallest set of devices that are considered
> to be isolated. All devices belonging to an IOMMU group share a default
> domain for DMA APIs. There are two types of default domain: IOMMU_DOMAIN_DMA
> and IOMMU_DOMAIN_IDENTITY. The former means IOMMU translation, while the
> latter means IOMMU by-pass.
>
> Currently, the default domain type for the IOMMU groups is determined
> globally. All IOMMU groups use a single default domain type. The global
> default domain type can be adjusted by kernel build configuration or
> kernel parameters.
>
> More and more users are looking forward to a fine grained default domain
> type. For example, with the global default domain type set to translation,
> the OEM verndors or end users might want some trusted and fast-speed devices
> to bypass IOMMU for performance gains. On the other hand, with global
> default domain type set to by-pass, some devices with limited system
> memory addressing capability might want IOMMU translation to remove the
> bounce buffer overhead.
Hi Lu Baolu,
Do you think that it would be a more common usecase to want
kernel-managed devices to be passthrough for performance reasons and
some select devices to be in DMA domain, like those with limited address
cap or whose drivers request huge amounts of memory?
I just think it would be more manageable to set kernel commandline
parameters for this, i.e. those select few which want DMA domain.
Thanks,
John
>
> This series proposes per-group default domain type to meet these demands.
> It adds a per-device iommu_passthrough attribute. By setting this
> attribute, end users or device vendors are able to tell the IOMMU subsystem
> that this device is willing to use a default domain of IOMMU_DOMAIN_IDENTITY.
> The IOMMU device probe procedure is reformed to pre-allocate groups for
> all devices on a specific bus before adding the devices into the groups.
> This enables the IOMMU device probe precedure to determine a per-group
> default domain type before allocating IOMMU domains and attaching them
> to devices.
>
> Please help to review it. Your comments and suggestions are appricated.
>
> Best regards,
> baolu
>
> Lu Baolu (4):
> driver core: Add iommu_passthrough to struct device
> PCI: Add "pci=iommu_passthrough=" parameter for iommu passthrough
> iommu: Preallocate iommu group when probing devices
> iommu: Determine default domain type before allocating domain
>
> .../admin-guide/kernel-parameters.txt | 5 +
> drivers/iommu/iommu.c | 127 ++++++++++++++----
> drivers/pci/pci.c | 34 +++++
> drivers/pci/pci.h | 1 +
> drivers/pci/probe.c | 2 +
> include/linux/device.h | 3 +
> 6 files changed, 143 insertions(+), 29 deletions(-)
>
next prev parent reply other threads:[~2020-01-20 9:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 5:26 [RFC PATCH 0/4] iommu: Per-group default domain type Lu Baolu
2020-01-01 5:26 ` [RFC PATCH 1/4] driver core: Add iommu_passthrough to struct device Lu Baolu
2020-01-01 5:26 ` [RFC PATCH 2/4] PCI: Add "pci=iommu_passthrough=" parameter for iommu passthrough Lu Baolu
2020-01-18 0:18 ` Bjorn Helgaas
2020-01-18 2:04 ` Lu Baolu
2020-01-21 14:17 ` Bjorn Helgaas
2020-01-22 4:49 ` Lu Baolu
2020-01-01 5:26 ` [RFC PATCH 3/4] iommu: Preallocate iommu group when probing devices Lu Baolu
2020-01-17 10:21 ` Joerg Roedel
2020-01-18 2:18 ` Lu Baolu
2020-01-19 6:29 ` Lu Baolu
2020-01-21 12:45 ` Robin Murphy
2020-01-22 5:39 ` Lu Baolu
2020-01-23 14:55 ` Robin Murphy
2020-01-01 5:26 ` [RFC PATCH 4/4] iommu: Determine default domain type before allocating domain Lu Baolu
2020-01-20 9:44 ` John Garry [this message]
2020-01-21 0:43 ` [RFC PATCH 0/4] iommu: Per-group default domain type Lu Baolu
2020-01-21 10:14 ` John Garry
2020-01-22 4:58 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7a7e6a-8b23-fca0-a8bb-72c4dbfa8390@huawei.com \
--to=john.garry@huawei.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).