From: Sander Vanheule <sander@svanheule.net>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Adrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support"
Date: Wed, 09 Jun 2021 14:42:06 +0200 [thread overview]
Message-ID: <ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net> (raw)
In-Reply-To: <20210609122401.GA20286@sirena.org.uk>
On Wed, 2021-06-09 at 13:24 +0100, Mark Brown wrote:
> On Wed, Jun 09, 2021 at 01:46:05PM +0200, Sander Vanheule wrote:
> > This reverts commit f083be9db060fbac09123d80bdffb2c001ac0e2b.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
I had grepped the commit log for other reverting patches, which also appear to
use this style, but I didn't check the regmap-specific ones.
> > There are currently no (planned) regmap users for C45 register access.
> > Remove support for now, to reduce dead code.
>
> This then creates a bootstrapping issue for anyone who does need it - I
> can't see any way in which this causes problems or gets in the way?
If you would rather keep this, I should modify the other patch (regmap: mdio:
Reject invalid clause-22 addresses) to also cover C45 addresses.
Furthermore, there's an issue with a pointer const-ness in __regmap_init_mdio
that needs to be fixed if this code is staying.
I'll submit a v2 that fixes __regmap_init_mdio, and also applies the address
checks to C45 access.
Best,
Sander
next prev parent reply other threads:[~2021-06-09 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:46 [PATCH 0/2] Clause-22/Clause-45 MDIO regmap support fixups Sander Vanheule
2021-06-09 11:46 ` [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support" Sander Vanheule
2021-06-09 12:24 ` Mark Brown
2021-06-09 12:42 ` Sander Vanheule [this message]
2021-06-09 13:23 ` Mark Brown
2021-06-09 11:46 ` [PATCH 2/2] regmap: mdio: Reject invalid clause-22 addresses Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net \
--to=sander@svanheule.net \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).