From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbdHBLO3 (ORCPT ); Wed, 2 Aug 2017 07:14:29 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36819 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753066AbdHBLOZ (ORCPT ); Wed, 2 Aug 2017 07:14:25 -0400 Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable To: Arnd Bergmann , Bartlomiej Zolnierkiewicz , Dan Carpenter , Sean Paul , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170802093722.3666961-1-arnd@arndb.de> <20170802100124.bcr3ux6bt4hnlu6r@phenom.ffwll.local> From: Arvind Yadav Message-ID: Date: Wed, 2 Aug 2017 16:44:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170802100124.bcr3ux6bt4hnlu6r@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, With is change we can get below error. If MODULE is define. drivers/video/fbdev/matrox/matroxfb_base.c: In function ‘initMatrox2’: drivers/video/fbdev/matrox/matroxfb_base.c:1799:23: error: ‘hotplug’ undeclared (first use in this function) minfo->fbcon.flags = hotplug ? FBINFO_FLAG_MODULE : FBINFO_FLAG_DEFAULT; Please check this. ~arvind On Wednesday 02 August 2017 03:31 PM, Daniel Vetter wrote: > On Wed, Aug 02, 2017 at 11:36:47AM +0200, Arnd Bergmann wrote: >> The variable has become unused in modular configurations >> which triggers a harmless warning: >> >> drivers/video/fbdev/matrox/matroxfb_base.c:1583:12: error: 'hotplug' defined but not used [-Werror=unused-variable] >> >> This moves it into an #ifdef section of the file, matching >> all its references. >> >> Fixes: 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE") >> Signed-off-by: Arnd Bergmann > Reviewed-by: Daniel Vetter > >> --- >> drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c >> index fd1589fcdf15..00ea4e4ab95a 100644 >> --- a/drivers/video/fbdev/matrox/matroxfb_base.c >> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c >> @@ -1578,9 +1578,9 @@ static struct fb_videomode defaultmode = { >> NULL, 60, 640, 480, 39721, 40, 24, 32, 11, 96, 2, >> 0, FB_VMODE_NONINTERLACED >> }; >> -#endif /* !MODULE */ >> >> static int hotplug = 0; >> +#endif /* !MODULE */ >> >> static void setDefaultOutputs(struct matrox_fb_info *minfo) >> { >> -- >> 2.9.0 >>