From: Topi Miettinen <toiwoton@gmail.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: linux-hardening@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
Linux API <linux-api@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v4] mm/vmalloc: randomize vmalloc() allocations
Date: Mon, 15 Mar 2021 13:45:18 +0200 [thread overview]
Message-ID: <ba975607-9493-c78c-bbd8-6a85573114d1@gmail.com> (raw)
In-Reply-To: <20210314172312.GA2085@pc638.lan>
On 14.3.2021 19.23, Uladzislau Rezki wrote:
> Also, using vmaloc test driver i can trigger a kernel BUG:
>
> <snip>
> [ 24.627577] kernel BUG at mm/vmalloc.c:1272!
It seems that most tests indeed fail. Perhaps the vmalloc subsystem
isn't very robust in face of fragmented virtual memory. What could be
done to fix that?
In this patch, I could retry __alloc_vmap_area() with the whole region
after failure of both [random, vend] and [vstart, random] but I'm not
sure that would help much. Worth a try of course.
By the way, some of the tests in test_vmalloc.c don't check for
vmalloc() failure, for example in full_fit_alloc_test().
-Topi
next prev parent reply other threads:[~2021-03-15 11:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:57 [PATCH v4] mm/vmalloc: randomize vmalloc() allocations Topi Miettinen
2021-03-14 17:23 ` Uladzislau Rezki
2021-03-15 9:04 ` Topi Miettinen
2021-03-15 12:24 ` Uladzislau Rezki
2021-03-15 16:16 ` Kees Cook
2021-03-15 17:47 ` Uladzislau Rezki
2021-03-16 8:01 ` Topi Miettinen
2021-03-16 11:34 ` Uladzislau Rezki
2021-03-15 11:45 ` Topi Miettinen [this message]
2021-03-15 15:35 ` Uladzislau Rezki
2021-03-15 16:23 ` Topi Miettinen
2021-03-15 18:02 ` Uladzislau Rezki
2021-03-16 7:01 ` Topi Miettinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba975607-9493-c78c-bbd8-6a85573114d1@gmail.com \
--to=toiwoton@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=rppt@kernel.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).