From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Micah Morton <mortonm@chromium.org>, Gao Xiang <xiang@kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
Thomas Cedeno <thomascedeno@google.com>
Subject: [PATCH 2/2] groups: Simplify struct group_info allocation
Date: Tue, 26 Jan 2021 02:37:16 +0100 [thread overview]
Message-ID: <ba9ba5beea9a44b7196c41a0d9528abd5f20dd2e.1611620846.git.hubert.jasudowicz@gmail.com> (raw)
In-Reply-To: <155995eed35c3c1bdcc56e69d8997c8e4c46740a.1611620846.git.hubert.jasudowicz@gmail.com>
Combine kmalloc and vmalloc into a single call.
Use struct_size macro instead of direct size calculation.
Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
---
kernel/groups.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/kernel/groups.c b/kernel/groups.c
index fe7e6385530e..787b381c7c00 100644
--- a/kernel/groups.c
+++ b/kernel/groups.c
@@ -15,12 +15,7 @@
struct group_info *groups_alloc(int gidsetsize)
{
struct group_info *gi;
- unsigned int len;
-
- len = sizeof(struct group_info) + sizeof(kgid_t) * gidsetsize;
- gi = kmalloc(len, GFP_KERNEL_ACCOUNT|__GFP_NOWARN|__GFP_NORETRY);
- if (!gi)
- gi = __vmalloc(len, GFP_KERNEL_ACCOUNT);
+ gi = kvmalloc(struct_size(gi, gid, gidsetsize), GFP_KERNEL_ACCOUNT);
if (!gi)
return NULL;
--
2.30.0
prev parent reply other threads:[~2021-01-26 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 1:37 [PATCH 1/2] groups: Use flexible-array member in struct group_info Hubert Jasudowicz
2021-01-26 1:37 ` Hubert Jasudowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9ba5beea9a44b7196c41a0d9528abd5f20dd2e.1611620846.git.hubert.jasudowicz@gmail.com \
--to=hubert.jasudowicz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mortonm@chromium.org \
--cc=peterz@infradead.org \
--cc=thomascedeno@google.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).