From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E78C6778A for ; Tue, 3 Jul 2018 16:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B05B22BD0 for ; Tue, 3 Jul 2018 16:58:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B05B22BD0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934126AbeGCQ6N (ORCPT ); Tue, 3 Jul 2018 12:58:13 -0400 Received: from mga17.intel.com ([192.55.52.151]:63300 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932410AbeGCQ6M (ORCPT ); Tue, 3 Jul 2018 12:58:12 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:58:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="52355493" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by fmsmga008.fm.intel.com with ESMTP; 03 Jul 2018 09:58:11 -0700 Subject: Re: [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Andrew Jeffery , Joel Stanley References: <20180621193721.20588-1-jae.hyun.yoo@linux.intel.com> <20180621193947.20645-1-jae.hyun.yoo@linux.intel.com> <20180703164731.GA9150@rob-hp-laptop> From: Jae Hyun Yoo Message-ID: Date: Tue, 3 Jul 2018 09:58:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180703164731.GA9150@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks for the review. Please see my inline answer. On 7/3/2018 9:47 AM, Rob Herring wrote: > On Thu, Jun 21, 2018 at 12:39:47PM -0700, Jae Hyun Yoo wrote: >> This commit adds a document of generic PECI bus, adapter and client >> driver. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Andrew Jeffery >> Cc: Joel Stanley >> --- >> .../devicetree/bindings/peci/peci.txt | 60 +++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/peci/peci.txt >> >> diff --git a/Documentation/devicetree/bindings/peci/peci.txt b/Documentation/devicetree/bindings/peci/peci.txt >> new file mode 100644 >> index 000000000000..5583aa80b78a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/peci/peci.txt >> @@ -0,0 +1,60 @@ >> +Generic device tree configuration for PECI buses >> +================================================ >> + >> +Required properties: >> +- compatible : Should be "simple-bus". >> +- #address-cells : Should be present if the device has sub-nodes. >> +- #size-cells : Should be present if the device has sub-nodes. >> +- ranges : Should contain PECI controller registers ranges. >> + >> +Example: >> + peci: peci@10000000 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x10000000 0x1000>; >> + }; > > I don't think you need this section. It's just the parent of the > controller, right? > Right. I'll drop this section out. Thanks a lot, Jae >> + >> +Generic device tree configuration for PECI adapters >> +=================================================== >> + >> +Required properties: >> +- #address-cells : Should be <1>. Read more about client addresses below. >> +- #size-cells : Should be <0>. Read more about client addresses below. >> + >> +The cells properties above define that an address of CPU clients of a PECI bus >> +are described by a single value. >> + >> +Example: >> + peci0: peci-bus@0 { >> + compatible = "vendor,soc-peci"; >> + reg = <0x0 0x1000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + }; >> + >> +Generic device tree configuration for PECI clients >> +================================================== >> + >> +Required properties: >> +- compatible : Should contain name of PECI client. >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients starts from 0x30 based on PECI specification. >> + >> +Example: >> + peci-bus@0 { >> + compatible = "vendor,soc-peci"; >> + reg = <0x0 0x1000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + peci-client@30 { >> + compatible = "vendor,peci-client"; >> + reg = <0x30>; >> + }; >> + >> + peci-client@31 { >> + compatible = "vendor,peci-client"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.17.1 >>