* [PATCH] atm: horizon: remove h from printk format specifier
@ 2020-12-15 14:24 trix
2020-12-15 20:13 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-12-15 14:24 UTC (permalink / raw)
To: 3chas3; +Cc: linux-atm-general, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/atm/horizon.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 4f2951cbe69c..e110c305fc9c 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -1609,7 +1609,7 @@ static int hrz_send (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
if (*s++ == 'D') {
for (i = 0; i < 4; ++i)
d = (d << 4) | hex_to_bin(*s++);
- PRINTK (KERN_INFO, "debug bitmap is now %hx", debug = d);
+ PRINTK (KERN_INFO, "debug bitmap is now %x", debug = d);
}
}
#endif
@@ -2675,7 +2675,7 @@ static int hrz_probe(struct pci_dev *pci_dev,
"changing", lat, pci_lat);
pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, pci_lat);
} else if (lat < MIN_PCI_LATENCY) {
- PRINTK(KERN_INFO, "%s PCI latency timer from %hu to %hu",
+ PRINTK(KERN_INFO, "%s PCI latency timer from %u to %u",
"increasing", lat, MIN_PCI_LATENCY);
pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, MIN_PCI_LATENCY);
}
@@ -2777,7 +2777,7 @@ static void hrz_remove_one(struct pci_dev *pci_dev)
static void __init hrz_check_args (void) {
#ifdef DEBUG_HORIZON
- PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK);
+ PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK);
#else
if (debug)
PRINTK (KERN_NOTICE, "no debug support in this image");
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atm: horizon: remove h from printk format specifier
2020-12-15 14:24 [PATCH] atm: horizon: remove h from printk format specifier trix
@ 2020-12-15 20:13 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-12-15 20:13 UTC (permalink / raw)
To: trix, Chas Williams; +Cc: linux-atm-general, netdev, linux-kernel
On Tue, 2020-12-15 at 06:24 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/atm/horizon.c | 6 +++---
Chas?
Madge has been out of business for a couple decades now.
I doubt anyone does but does anyone actually use this driver or
even have working hardware?
If not, how about just deleting this driver altogether instead?
from horizon.h:
/*
Madge Horizon ATM Adapter driver.
Copyright (C) 1995-1999 Madge Networks Ltd.
*/
/*
IMPORTANT NOTE: Madge Networks no longer makes the adapters
supported by this driver and makes no commitment to maintain it.
*/
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
[]
> @@ -1609,7 +1609,7 @@ static int hrz_send (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
> if (*s++ == 'D') {
> for (i = 0; i < 4; ++i)
> d = (d << 4) | hex_to_bin(*s++);
> - PRINTK (KERN_INFO, "debug bitmap is now %hx", debug = d);
> + PRINTK (KERN_INFO, "debug bitmap is now %x", debug = d);
An IMO ugly assignment in a printk too.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-15 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 14:24 [PATCH] atm: horizon: remove h from printk format specifier trix
2020-12-15 20:13 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).