From: Roger Quadros <rogerq@ti.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: <balbi@kernel.org>, <robh+dt@kernel.org>, <vigneshr@ti.com>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] usb: dwc3: keystone: Turn on USB3 PHY before controller
Date: Thu, 14 May 2020 10:40:18 +0300 [thread overview]
Message-ID: <baaaf89c-4baf-4218-e22e-53cd1a64ec02@ti.com> (raw)
In-Reply-To: <1589420265.5899.0.camel@mhfsdcap03>
On 14/05/2020 04:37, Chunfeng Yun wrote:
> On Wed, 2020-05-13 at 16:07 +0300, Roger Quadros wrote:
>> The Local Power Sleep Controller (LPSC) dependency on AM65
>> requires SERDES0 to be powered on before USB.
>>
>> We need to power up SERDES0 power domain and hold it on
>> throughout the reset, init, power on sequence.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> drivers/usb/dwc3/dwc3-keystone.c | 47 +++++++++++++++++++++++++++++++-
>> 1 file changed, 46 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
>> index 1e14a6f4884b..46d46f3507fc 100644
>> --- a/drivers/usb/dwc3/dwc3-keystone.c
>> +++ b/drivers/usb/dwc3/dwc3-keystone.c
>> @@ -14,6 +14,7 @@
>> #include <linux/dma-mapping.h>
>> #include <linux/io.h>
>> #include <linux/of_platform.h>
>> +#include <linux/phy/phy.h>
>> #include <linux/pm_runtime.h>
>>
>> /* USBSS register offsets */
>> @@ -34,6 +35,7 @@
>> struct dwc3_keystone {
>> struct device *dev;
>> void __iomem *usbss;
>> + struct phy *usb3_phy;
>> };
>>
>> static inline u32 kdwc3_readl(void __iomem *base, u32 offset)
>> @@ -95,8 +97,44 @@ static int kdwc3_probe(struct platform_device *pdev)
>> if (IS_ERR(kdwc->usbss))
>> return PTR_ERR(kdwc->usbss);
>>
>> - pm_runtime_enable(kdwc->dev);
>> + /* PSC dependency on AM65 needs SERDES0 to be powered before USB0 */
>> + kdwc->usb3_phy = devm_phy_get(dev, "usb3-phy");
> Use devm_phy_optional_get() instead?
Indeed, it seems better suited.
cheers,
-roger
>
>> + if (IS_ERR(kdwc->usb3_phy)) {
>> + error = PTR_ERR(kdwc->usb3_phy);
>> + if (error == -ENOSYS || error == -ENODEV) {
>> + kdwc->usb3_phy = NULL;
>> + } else {
>> + if (error != -EPROBE_DEFER) {
>> + dev_err(dev, "couldn't get usb3 phy: %d\n",
>> + error);
>> + }
>> +
>> + return error;
>> + }
>> + }
>> +
>> + phy_pm_runtime_get_sync(kdwc->usb3_phy);
>> +
>> + error = phy_reset(kdwc->usb3_phy);
>> + if (error < 0) {
>> + dev_err(dev, "usb3 phy reset failed: %d\n", error);
>> + return error;
>> + }
>> +
>> + error = phy_init(kdwc->usb3_phy);
>> + if (error < 0) {
>> + dev_err(dev, "usb3 phy init failed: %d\n", error);
>> + return error;
>> + }
>>
>> + error = phy_power_on(kdwc->usb3_phy);
>> + if (error < 0) {
>> + dev_err(dev, "usb3 phy power on failed: %d\n", error);
>> + phy_exit(kdwc->usb3_phy);
>> + return error;
>> + }
>> +
>> + pm_runtime_enable(kdwc->dev);
>> error = pm_runtime_get_sync(kdwc->dev);
>> if (error < 0) {
>> dev_err(kdwc->dev, "pm_runtime_get_sync failed, error %d\n",
>> @@ -138,6 +176,9 @@ static int kdwc3_probe(struct platform_device *pdev)
>> err_irq:
>> pm_runtime_put_sync(kdwc->dev);
>> pm_runtime_disable(kdwc->dev);
>> + phy_power_off(kdwc->usb3_phy);
>> + phy_exit(kdwc->usb3_phy);
>> + phy_pm_runtime_put_sync(kdwc->usb3_phy);
>>
>> return error;
>> }
>> @@ -163,6 +204,10 @@ static int kdwc3_remove(struct platform_device *pdev)
>> pm_runtime_put_sync(kdwc->dev);
>> pm_runtime_disable(kdwc->dev);
>>
>> + phy_power_off(kdwc->usb3_phy);
>> + phy_exit(kdwc->usb3_phy);
>> + phy_pm_runtime_put_sync(kdwc->usb3_phy);
>> +
>> platform_set_drvdata(pdev, NULL);
>>
>> return 0;
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-05-14 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 13:07 [PATCH 0/3] usb: dwc3: keystone: Convert binding to YAML Roger Quadros
2020-05-13 13:07 ` [PATCH 1/3] dt-bindings: usb: convert keystone-usb.txt " Roger Quadros
2020-05-27 1:37 ` Rob Herring
2020-06-02 12:36 ` Roger Quadros
2020-05-13 13:07 ` [PATCH 2/3] dt-bindings: usb: ti,keystone-dwc3.yaml: Add USB3.0 PHY property Roger Quadros
2020-05-13 13:07 ` [PATCH 3/3] usb: dwc3: keystone: Turn on USB3 PHY before controller Roger Quadros
2020-05-14 1:37 ` Chunfeng Yun
2020-05-14 7:40 ` Roger Quadros [this message]
2020-05-14 10:21 ` Felipe Balbi
2020-05-25 6:39 ` Roger Quadros
2020-05-25 6:41 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baaaf89c-4baf-4218-e22e-53cd1a64ec02@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).