From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABCBC433B4 for ; Mon, 12 Apr 2021 17:29:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50D1061246 for ; Mon, 12 Apr 2021 17:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242790AbhDLR3n (ORCPT ); Mon, 12 Apr 2021 13:29:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241741AbhDLR3m (ORCPT ); Mon, 12 Apr 2021 13:29:42 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5D4FC061574; Mon, 12 Apr 2021 10:29:23 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id g24so10544181qts.6; Mon, 12 Apr 2021 10:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=yZERBifSmi4SCI1KUema3RU8NgjctejDx9aUtqw4gYc=; b=ZsMLMbY/5LeKJ24JnODzYecHvpel/efJj5r99xrz9pbYuq4xD0PeTgcXOWtGby5hHb UpOe1q2HIHFEUjuRyjz8F/UaAIunpAGMCL7hzEJAO4P3IT9g3dc8yYvOgoBof02Jr09k 6ME2i1jtqUUKtJ1CQoX/Y56ePkZTYYd+2HoRYUdDVR7xHkYMfxEJSml/iioHV1VsFL+P fs3dqbOpmBfZHt9iWV9BKTDj6ksVRPRIU+t+U27jQk/sr5Wpp+5iLiXsmO8se0q7eMAP RYq7iM+v7LiIzJ/5R/zG1U9tyIrkM7OftqYlT2DQbptQT2d68TrZ/qKte7M+x8K+/9BA zA6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=yZERBifSmi4SCI1KUema3RU8NgjctejDx9aUtqw4gYc=; b=X3GoSX6yCI5gc+P3wY9RSkAUyJ1JOXXyWjQ4kFdcG4l5qHA0J9yD1e93sf3wnUim+0 9GU7+kKL7y79dm9bErk4s1FK1N5JDCPgmCjyat7JZ+gBiXJFHaqr07dteAfPpKSweqV7 keMUpY3wpFGV+ozc4JxPf/e6qiHTlaU3nqZ+cEOHdRMUdYjh8aL01ncLfHDdH1KXkeZ/ Eu0XT2xm/qaGO9/tzP38T5rHJMkIPWlASHSu0S+G2cfF7pNgVlinZfPtpRkAdm12QOja dqQ2Vvg4AV14mnfVCdjDdpLUcc2Og6SKUWzqml2qvbEUHc4Kzazvt2Icv+55/An9utsZ ARiw== X-Gm-Message-State: AOAM5327lsP/EMuv4xoaEEhZ3sALtdWZIJX3ELCQ6QTODUHQfS8xqZug Vem0xWDq/bw3+sNIaa+6y/E= X-Google-Smtp-Source: ABdhPJxzjI5Rl2q1EiTW7SB4I1X8txmmBiS8CnzNYr2HT/4U+cqVdMO9YjZcSEvmcnk3khIExr0AsA== X-Received: by 2002:ac8:7241:: with SMTP id l1mr13586554qtp.13.1618248561779; Mon, 12 Apr 2021 10:29:21 -0700 (PDT) Received: from ?IPv6:2001:1284:f016:a037:29a:1b49:fcb:5776? ([2001:1284:f016:a037:29a:1b49:fcb:5776]) by smtp.gmail.com with ESMTPSA id t198sm4363812qke.44.2021.04.12.10.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 10:29:21 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c From: ascordeiro To: Laurent Pinchart Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Mon, 12 Apr 2021 14:29:18 -0300 In-Reply-To: References: <7457fd4eb5afbf66b3a6f2fed4dd1e440e6ed422.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.0 (by Flathub.org) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu: > Hi Aline, > > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote: > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu: > > > While testing on a device isn't a requirement as you can't be > > > expected > > > to have the necessary hardware, changes are expected to be at > > > least > > > compile-tested before being submitted. > > > > Hi Laurent, > > > > I thought recompiling the kernel would be enough in this case. > > I recompiled it in native Ubuntu 16.04 without errors. > > Did it compile the driver you modified ? > I'm sorry, It didn't. I forgot to enable the option to compile the driver as a module in "make menuconfig" and now I'm seeing the problems I generated. Thank you for warning me, Aline