From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Jiri Pirko <jiri@resnulli.us>, Sekhar Nori <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Murali Karicheri <m-karicheri2@ti.com>,
Ivan Vecera <ivecera@redhat.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 net-next 06/13] dt-bindings: net: ti: add new cpsw switch driver bindings
Date: Tue, 12 Nov 2019 11:53:50 +0200 [thread overview]
Message-ID: <bac9a300-cbd5-d342-a96d-d90fdcf2e4c3@ti.com> (raw)
In-Reply-To: <20191111172652.GV5610@atomide.com>
On 11/11/2019 19:26, Tony Lindgren wrote:
> Hi,
>
> * Grygorii Strashko <grygorii.strashko@ti.com> [191109 15:17]:
>> + mac_sw: switch@0 {
>> + compatible = "ti,dra7-cpsw-switch","ti,cpsw-switch";
>> + reg = <0x0 0x4000>;
>> + ranges = <0 0 0x4000>;
>> + clocks = <&gmac_main_clk>;
>> + clock-names = "fck";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + syscon = <&scm_conf>;
>> + inctrl-names = "default", "sleep";
>> +
>> + interrupts = <GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "rx_thresh", "rx", "tx", "misc";
>
> I think with the ti-sysc managing the interconnect target module as the
> parent of this, you should be able add all the modules as direct children
> of ti-sysc with minor fixups. This would simplify things, and makes it
> easier to update the driver later on when the child modules get
> changed/updated/moved around.
>
> The child modules just need to call PM runtime to have access to their
> registers, and whatever cpsw control module part could be a separate
> driver providing Linux standard services for example for clock gating :)
>
>> + davinci_mdio_sw: mdio@1000 {
>> + compatible = "ti,cpsw-mdio","ti,davinci_mdio";
>> + reg = <0x1000 0x100>;
>> + clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
>> + clock-names = "fck";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + bus_freq = <1000000>;
>> +
>> + ethphy0_sw: ethernet-phy@0 {
>> + reg = <0>;
>> + };
>> +
>> + ethphy1_sw: ethernet-phy@1 {
>> + reg = <41>;
>> + };
>> + };
>
> And in this case, mdio above would just move up one level.
>
> This goes back to my earlier comments saying the cpsw is really just
> a private interconnect with a collection of various mostly independent
> modules. Sounds like you're heading that way already though at the
> driver level :)
No, sorry I do not agree. The MDIO is inseparable part of CPSW and it's enabled when CPSW is enabled
(on interconnect level), more over I want to get rid of platform device in MDIO for most of the cases
as it only introduces boot/probing complexity.
The same is valid for CPTS.
--
Best regards,
grygorii
next prev parent reply other threads:[~2019-11-12 9:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 15:15 [PATCH v6 net-next 00/13] net: ethernet: ti: introduce new cpsw switchdev based driver Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 01/13] net: ethernet: ti: ale: clean ale tbl on init and intf restart Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 02/13] net: ethernet: ti: cpsw: allow untagged traffic on host port Grygorii Strashko
2019-11-11 22:38 ` David Miller
2019-11-09 15:15 ` [PATCH v6 net-next 03/13] net: ethernet: ti: ale: modify vlan/mdb api for switchdev Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 04/13] net: ethernet: ti: cpsw: resolve build deps of cpsw drivers Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 05/13] net: ethernet: ti: cpsw: move set of common functions in cpsw_priv Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 06/13] dt-bindings: net: ti: add new cpsw switch driver bindings Grygorii Strashko
2019-11-11 17:26 ` Tony Lindgren
2019-11-12 9:53 ` Grygorii Strashko [this message]
2019-11-12 16:22 ` Tony Lindgren
2019-11-12 19:06 ` Rob Herring
2019-11-09 15:15 ` [PATCH v6 net-next 07/13] net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 08/13] net: ethernet: ti: introduce cpsw switchdev based driver part 2 - switch Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 09/13] phy: ti: phy-gmii-sel: dependency from ti cpsw-switchdev driver Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 10/13] Documentation: networking: add cpsw switchdev based driver documentation Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 11/13] ARM: dts: dra7: add dt nodes for new cpsw switch dev driver Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 12/13] ARM: dts: am571x-idk: enable " Grygorii Strashko
2019-11-09 15:15 ` [PATCH v6 net-next 13/13] arm: omap2plus_defconfig: enable new cpsw switchdev driver Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac9a300-cbd5-d342-a96d-d90fdcf2e4c3@ti.com \
--to=grygorii.strashko@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).