From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Arnd Bergmann <arnd@arndb.de>, kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@lists.codethink.co.uk,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
Peter Chen <peter.chen@freescale.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: fix missing include <linux/usb/of.h>
Date: Thu, 16 Jun 2016 14:02:37 +0100 [thread overview]
Message-ID: <badbed20-493c-b25b-4e8e-c9af2d45a33e@codethink.co.uk> (raw)
In-Reply-To: <16060867.1nFmu0b2lQ@wuerfel>
On 14/06/16 12:08, Arnd Bergmann wrote:
> On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote:
>>>> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node'
>> struct device_node *usb_of_get_child_node(struct device_node *parent,
>> ^~~~~~~~~~~~~~~~~~~~~
>> In file included from drivers/usb/core/of.c:21:0:
>> include/linux/usb/of.h:36:35: note: previous definition of 'usb_of_get_child_node' was here
>> static inline struct device_node *usb_of_get_child_node
>> ^~~~~~~~~~~~~~~~~~~~~
>>
>> vim +/usb_of_get_child_node +32 drivers/usb/core/of.c
>>
>> 69bec725 Peter Chen 2016-02-19 26 * @portnum: the port number which device is connecting
>> 69bec725 Peter Chen 2016-02-19 27 *
>> 69bec725 Peter Chen 2016-02-19 28 * Find the node from device tree according to its port number.
>> 69bec725 Peter Chen 2016-02-19 29 *
>> 69bec725 Peter Chen 2016-02-19 30 * Return: On success, a pointer to the device node, %NULL on failure.
>> 69bec725 Peter Chen 2016-02-19 31 */
>> 69bec725 Peter Chen 2016-02-19 @32 struct device_node *usb_of_get_child_node(struct device_node *parent,
>> 69bec725 Peter Chen 2016-02-19 33 int portnum)
>> 69bec725 Peter Chen 2016-02-19 34 {
>> 69bec725 Peter Chen 2016-02-19 35 struct device_node *node;
>>
>>
>
> I think what we want here is to make the compilation of of.o conditional on
> CONFIG_OF, so we get only one of the two definitions.
Ah, so make the of.o conditional, and also apply my patch for when
it is compiled.
Should I submit one for that, or is someone else on the case?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2016-06-16 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:20 [PATCH] USB: core: fix missing include <linux/usb/of.h> Ben Dooks
2016-06-07 19:04 ` kbuild test robot
2016-06-14 11:08 ` Arnd Bergmann
2016-06-15 2:43 ` Peter Chen
2016-06-16 12:45 ` Ben Dooks
2016-06-16 13:02 ` Ben Dooks [this message]
2016-06-17 1:31 ` Peter Chen
2016-06-14 1:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=badbed20-493c-b25b-4e8e-c9af2d45a33e@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.chen@freescale.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).