From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcHQK2y (ORCPT ); Wed, 17 Aug 2016 06:28:54 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:42318 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbcHQK2x (ORCPT ); Wed, 17 Aug 2016 06:28:53 -0400 X-AuditID: cbfec7f4-f796c6d000001486-08-57b43c61a6d8 Subject: Re: [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and add serial options to Odroid XU/XU3/XU4 To: Mark Rutland References: <1471419298-10414-1-git-send-email-k.kozlowski@samsung.com> <20160817102506.GD30900@leverpostej> Cc: Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: Date: Wed, 17 Aug 2016 12:28:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20160817102506.GD30900@leverpostej> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xq7qJNlvCDb7/k7PYOGM9q8X8I+dY LV6/MLTof/ya2eL8+Q3sFpseX2O1uLxrDpvFjPP7mCyWXr/I5MDpsWbeGkaPTas62Tw2L6n3 6NuyitHj8ya5ANYoLpuU1JzMstQifbsEroxniy+wFkzgqLj7qbCB8QBbFyMnh4SAicSkV32s ELaYxIV764HiXBxCAksZJY6f2cwO4TxjlOje/YgJpEpYoFxi08Lt7CC2iIC6RM+uLywgtpBA nsS7a//BapgF2pkkbl5xBbHZBIwlNi9fAraNV8BOYur8/UA1HBwsAqoSExcIg4RFBSIkbq36 yAhRIijxY/I9sJGcAoYSjX8ngZUzC+hJ3L+oBTFdXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWM oqmlyQXFSem5hnrFibnFpXnpesn5uZsYIeH+ZQfj4mNWhxgFOBiVeHhvWm0OF2JNLCuuzD3E KMHBrCTC6225JVyINyWxsiq1KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwc nFINjOnlMw57Tb57a2FUQ1vIjGWav3YWGYfX3eMVURV/72Au/qiE/wPTWdc50r7nLx3uPbH/ pvAfgRNGQS/ue6yo0F4hLDpxtnir0R5Br7BnD++/Ph7Mv02u4uqtzwlpdnzshfUX2x+np/X/ dZtQ/qsqpnFPwjTrlF3nT3e9ExcQZN7O8pztaqm/vBJLcUaioRZzUXEiAERX7g9zAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 12:25 PM, Mark Rutland wrote: > On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote: >> The "linux,stdout-path" is deprecated. >> >> Add serial options so the console can be properly configured when >> bootloader does not pass "console" parameter to command line. Without >> options and lack of "console", the serial output dies during boot (just >> after probing sound). > > I'm confused. Is this just a cleanup (given "linux,stdout-path" is > deprecated but still supported), or a bug fix? There is no bug, so rather this is cleanup and improvement in one. Usually we pass full console=ttySAC2,115200n8 from UBoot to command line. The usage of serial options allows skipping that. I can split the cleanup part from improvement. To me it looked a little bit too much but I don't mind. > I guess that prior to this patch Linux might change the rate of the > console, but otherwise it should work. It still can be overridden by command line if needed. Best regards, Krzysztof