linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Alex Dewar <alex.dewar90@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Saiyam Doshi <saiyamdoshi.in@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Use standard BIT() macro
Date: Tue, 18 Aug 2020 07:29:02 -0700	[thread overview]
Message-ID: <baecb36e-1f82-1e0e-6460-d6759a9193c1@infradead.org> (raw)
In-Reply-To: <20200818134922.409195-1-alex.dewar90@gmail.com>

On 8/18/20 6:49 AM, Alex Dewar wrote:
> Currently emxx_udc.h defines bit values using local macros. Use the
> standard one instead.
> 
> Also, combine bit values with bitwise-or rather than addition, as
> suggested by Coccinelle.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>

Hi,

Does this build?  Just checking.

Looks like it would need this:

#include <linux/bits.h>

since it (indirectly) provides definition of the BIT() macro.

> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
>  1 file changed, 211 insertions(+), 245 deletions(-)


thanks.
-- 
~Randy


  reply	other threads:[~2020-08-18 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 13:49 [PATCH] staging: emxx_udc: Use standard BIT() macro Alex Dewar
2020-08-18 14:29 ` Randy Dunlap [this message]
2020-08-18 15:06   ` Alex Dewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baecb36e-1f82-1e0e-6460-d6759a9193c1@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=alex.dewar90@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saiyamdoshi.in@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).