From: kernel test robot <rong.a.chen@intel.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: chunkuang.hu@kernel.org, hsinyi@chromium.org,
kernel@collabora.com, drinkcat@chromium.org, eizan@chromium.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
jitao.shi@mediatek.com, Philipp Zabel <p.zabel@pengutronix.de>,
kbuild-all@lists.01.org
Subject: Re: [PATCH v2 6/7] soc: mediatek: mmsys: Add reset controller support
Date: Fri, 16 Jul 2021 17:01:36 +0800 [thread overview]
Message-ID: <baf4a35e-8025-460c-85b6-214ad23d7b89@intel.com> (raw)
In-Reply-To: <202107150857.sniQJ86e-lkp@intel.com>
Hi Enric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on pza/reset/next linux/master linus/master
v5.14-rc1 next-20210714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-support-to-the-mmsys-driver-to-be-a-reset-controller/20210714-181318
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/soc/mediatek/mtk-mmsys.c:104:6: warning: Unused variable: i [unusedVariable]
int i;
^
vim +104 drivers/soc/mediatek/mtk-mmsys.c
2c758e301ed95a Enric Balletbo i Serra 2020-03-25 97 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 98 static int
mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned long id,
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 99 bool assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 100 {
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 101 struct mtk_mmsys
*mmsys = container_of(rcdev, struct mtk_mmsys, rcdev);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 102 unsigned long flags;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 103 u32 reg;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 @104 int i;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 105 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 106 spin_lock_irqsave(&mmsys->lock,
flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 107 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 108 reg = readl_relaxed(mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 109 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 110 if (assert)
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 111 reg &= ~BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 112 else
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 113 reg |= BIT(id);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 114 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 115 writel_relaxed(reg, mmsys->regs
+ MMSYS_SW0_RST_B);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 116 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 117
spin_unlock_irqrestore(&mmsys->lock, flags);
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 118 08a3068f9490f0
Enric Balletbo i Serra 2021-07-14 119 return 0;
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 120 }
08a3068f9490f0 Enric Balletbo i Serra 2021-07-14 121
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-07-16 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202107150857.sniQJ86e-lkp@intel.com>
2021-07-16 8:58 ` kernel test robot
2021-07-16 9:01 ` kernel test robot [this message]
2021-07-14 10:11 [PATCH v2 0/7] Add support to the mmsys driver to be a reset controller Enric Balletbo i Serra
2021-07-14 10:11 ` [PATCH v2 6/7] soc: mediatek: mmsys: Add reset controller support Enric Balletbo i Serra
2021-07-20 10:52 ` Philipp Zabel
2021-07-20 17:07 ` Enric Balletbo i Serra
2021-07-21 9:53 ` Philipp Zabel
2021-08-06 17:34 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf4a35e-8025-460c-85b6-214ad23d7b89@intel.com \
--to=rong.a.chen@intel.com \
--cc=chunkuang.hu@kernel.org \
--cc=drinkcat@chromium.org \
--cc=eizan@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=jitao.shi@mediatek.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--subject='Re: [PATCH v2 6/7] soc: mediatek: mmsys: Add reset controller support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).