From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934407AbcLLRQR (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 12:16:17 -0500
Received: from mout.web.de ([212.227.15.3]:52018 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933505AbcLLRQM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 12:16:12 -0500
Subject: Re: [media] bt8xx: One function call less in bttv_input_init() after
 error detection
To: Daniele Nicolodi <daniele@grinta.net>
References: <d9a0777b-8ea7-3f7d-4fa2-b16468c4a1a4@users.sourceforge.net>
 <e20a6835-a404-e894-d0d0-a408bfcd7fb6@users.sourceforge.net>
 <ecf01283-e2eb-ecef-313f-123ba41c0336@grinta.net>
 <d3ab238e-02f0-2511-9be1-a1447e7639bc@users.sourceforge.net>
 <5560ffc2-e17d-5750-24e5-3150aba5d8aa@grinta.net>
 <ce612b15-0dff-ce33-6b22-3a2775bed4cd@users.sourceforge.net>
 <581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net>
Cc: linux-media@vger.kernel.org,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <baf6a24e-6a4e-f1ea-1b4d-7a3211964e4b@users.sourceforge.net>
Date: Mon, 12 Dec 2016 18:15:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:3biMvmMnjzsE4gS/oU9V7ESmhILyuehPFQUl/cvS76N2SDn98Zb
 9f1Wf24urnEjZ9agjVYRVmQazfsKqf/LDs0Xo1X8Af1195bTIOL4w+tcSDlGvU+1Knw8k/S
 FSDRcStoM8QYJrq8sueWJQSmQz/Q7tb68RXEfaLEXk8e9SPKUVWfzt4LXoHMUG4wm/cfY+q
 JBzyysLnkmrSuB96V/rhw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:GFO0tadhQ8c=:0klc2PwXge1GyaN6bXOcwr
 IvWQ30VpdvpYpMiVQ2cc4eNbv5Bug2bFUCqWTxcyATKY7QQmzA4ziHagdyw+xSq8IK40AhCmt
 KyLDctv6maoD5S0Pn9D1pPnEXk8YbMrWlFLb2qOXAzy7BjppHJ81OxRhfKm8muyg2s80b1Ni8
 skPTNGlbTIydh5wGqZfWbQqFMabVIjh26Jwu1n7LOSaAqfJ2NPcZLl9ClmKhzC2YrQCoQvhNH
 e1jcq/g0GwORvPZoYt1k7J7B7qYtjbkzKfJUqPAlANbvuJkU87xYo5J5Ccm1MAC2jeMP87tsZ
 KWnykS0ljoaCW3CGByNzvOxXfNal2+iIVAKBbj/8b/bfjWfbk+W9e22xFeGJ2ionPGI45aHbx
 Lr1NEW29lGIUi+hkzj6MySXUYPsAQcv0vumr3OcwmxC8BcyO5KzwwPMKAdd/oCNvCwpxJSvQQ
 7yW9KAFx6C/LNMiZA0LAhfMTvxyPs8OQRhOfymwcrD4Hp7c30Mlg/HvyOyKGu/3njQ7ntkEW0
 cDYxei2nvCvuPhmUedLX62qNCpc/BiAzDYvBMQq3edn/s+V6s4izBKi83biAiASHSZPOEaCIG
 ggdGcOojZcHayxk8AcZ75sv2WuATuNG+RR1Cm4cnmxTWiUYI2/Q9Meo4xTglcxCExDgKH+vQz
 gvtbY1yXCXYZsfn261q4S5mPMVr/ypAP+k9cpnOiwOScwxJ4zyuTl8b/orzuRz/eXxjQk4nyH
 dvgsU2vv2QjFwOQZ6vHLi2SN2QL0NQGQ+d+qWsd/JUYaFkLlcRXmubt+C982BlRDmiESkpQLQ
 AsAfPMJ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> I suggest to check return values immediately after each function call.
>> An error situation can be detected earlier then and only the required
>> clean-up functionality will be executed at the end.
> 
> Which improvement does this bring?

* How do you think about to avoid requesting additional system resources
  when it was determined that a previously required memory allocation failed?

* Can the corresponding exception handling become a bit more efficient?


> Why?

Do you care for any results from static source code analysis?

Regards,
Markus