From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44165C4727F for ; Thu, 1 Oct 2020 01:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C0AB20BED for ; Thu, 1 Oct 2020 01:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730531AbgJABHL (ORCPT ); Wed, 30 Sep 2020 21:07:11 -0400 Received: from mga12.intel.com ([192.55.52.136]:8006 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728660AbgJABHL (ORCPT ); Wed, 30 Sep 2020 21:07:11 -0400 IronPort-SDR: S3enRydT4cAp46T/xDqgRVNmaVPNhb4iMvHsJWc+8pgz/ZmkPqkwi14wQQHBnlo0n/Fwf6bd9h ME93+ek3t8yg== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="141993972" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="141993972" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 18:07:05 -0700 IronPort-SDR: aL1xFYH5NfFrPvYJiqGYGWqs04oPhr0Y4J5ZkkCYBrIakBkHzCRY/59YQRmWhFsufyDWNtvSH0 X1IVLU0JZH+A== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="457882317" Received: from rhweight-mobl2.amr.corp.intel.com (HELO [10.0.2.15]) ([10.212.91.128]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 18:07:03 -0700 Subject: Re: [PATCH v1 01/12] fpga: fpga security manager class driver To: Moritz Fischer Cc: lee.jones@linaro.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com References: <20200904235305.6254-1-russell.h.weight@intel.com> <20200904235305.6254-2-russell.h.weight@intel.com> <20200916201604.GA1076460@epycbox.lan> <20201001003101.GC121420@archbook> From: Russ Weight Message-ID: Date: Wed, 30 Sep 2020 18:07:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201001003101.GC121420@archbook> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Moritz, On 9/30/20 5:31 PM, Moritz Fischer wrote: > I think providing the devm_ managed APIs is nicer, and makes it easier > for the consumer of the API to do the right thing. I see that the fpga_mgr code has support for two versions of the create() and register() functions, one uses the devm_ approach, and the other does not. Would also want to have two versions for the security manager? - Russ