From: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
To: "Ondřej Jirman" <megi@xff.cz>,
"Nícolas F. R. A. Prado" <n@nfraprado.net>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de, martijn@brixit.nl, ayufan@ayufan.eu,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Mon, 22 Aug 2022 10:23:09 +1000 [thread overview]
Message-ID: <bb241882-a8c9-c2ea-a315-43d4929d4d96@tom-fitzhenry.me.uk> (raw)
In-Reply-To: <20220821090005.tshf7z2kklaet7ll@core>
On 21/8/22 19:00, Ondřej Jirman wrote:
> Max voltages in OPP table are irreleavant for Pinephone Pro DT, because the CPU
> regulators in the PMIC are capable of setting the preferred voltage or very
> close to it.
>
> The actual min/max limits that are enforced by the kernel for the board are set
> on the CPU regulator, which are actually wrongly set in this DT. See:
>
> https://dl.radxa.com/rockpi4/docs/hw/datasheets/Rockchip%20RK3399-T%20Datasheet%20V1.0-20210818.pdf
Good spot, I will fix these in v4.
next prev parent reply other threads:[~2022-08-22 0:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:30 [PATCH v3 0/2] Add support for the Pine64 PinePhone Pro phone Tom Fitzhenry
2022-08-15 12:30 ` [PATCH v3 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings Tom Fitzhenry
2022-08-15 22:27 ` Caleb Connolly
2022-08-16 7:50 ` Krzysztof Kozlowski
2022-08-15 12:30 ` [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Tom Fitzhenry
2022-08-15 22:26 ` Caleb Connolly
2022-08-16 7:52 ` Krzysztof Kozlowski
2022-08-22 0:04 ` Tom Fitzhenry
2022-08-18 3:05 ` Nícolas F. R. A. Prado
2022-08-21 9:00 ` Ondřej Jirman
2022-08-21 9:04 ` Ondřej Jirman
2022-08-22 0:23 ` Tom Fitzhenry [this message]
2022-08-22 0:19 ` Tom Fitzhenry
2022-08-21 0:11 ` Nícolas F. R. A. Prado
2022-08-22 0:33 ` Tom Fitzhenry
2022-09-04 17:22 ` (subset) [PATCH v3 0/2] Add support for the Pine64 PinePhone Pro phone Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb241882-a8c9-c2ea-a315-43d4929d4d96@tom-fitzhenry.me.uk \
--to=tom@tom-fitzhenry.me.uk \
--cc=ayufan@ayufan.eu \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=n@nfraprado.net \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).