linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
	jarkko.sakkinen@linux.intel.com
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca,
	mingo@redhat.com, jeffrin@rajagiritech.edu.in,
	linux-integrity@vger.kernel.org, will@kernel.org,
	peterhuewe@gmx.de
Subject: Re: [PATCH =v2 3/3] tpm: selftest: cleanup after unseal with wrong auth/policy test
Date: Thu, 12 Dec 2019 13:07:26 -0800	[thread overview]
Message-ID: <bb256d5a-5c8c-d5ec-5ad2-ddfaf1c83217@intel.com> (raw)
In-Reply-To: <1576184085.10287.13.camel@HansenPartnership.com>

On 12/12/19 12:54 PM, James Bottomley wrote:
> Not in the modern kernel resource manager world: anyone who is in the
> tpm group can access the tpmrm device and we haven't added a dangerous
> command filter like we promised we would, so unless they have actually
> set lockout or platform authorization, they'll find they can execute it

The default for the tpm2_* tools with '-T device' switch is to talk to
/dev/tpm0.

If one would try to run it, by mistake, it would fail with:

$ tpm2_clear -T device
ERROR:tcti:src/tss2-tcti/tcti-device.c:439:Tss2_Tcti_Device_Init()
Failed to open device file /dev/tpm0: Permission denied

To point it to /dev/tpmrm0 it would need to be:
$ tpm2_clear -T device:/dev/tpmrm0

-- 
Tadeusz

  reply	other threads:[~2019-12-12 21:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 17:48 [PATCH =v2 1/3] tpm: fix invalid locking in NONBLOCKING mode Tadeusz Struk
2019-12-12 17:48 ` [PATCH =v2 2/3] tpm: selftest: add test covering async mode Tadeusz Struk
2019-12-17  1:55   ` Jarkko Sakkinen
2019-12-12 17:48 ` [PATCH =v2 3/3] tpm: selftest: cleanup after unseal with wrong auth/policy test Tadeusz Struk
2019-12-12 19:51   ` James Bottomley
2019-12-12 20:49     ` Tadeusz Struk
2019-12-12 20:54       ` James Bottomley
2019-12-12 21:07         ` Tadeusz Struk [this message]
2019-12-12 21:11           ` James Bottomley
2019-12-17 10:37       ` Jarkko Sakkinen
2019-12-17  1:32 ` [PATCH =v2 1/3] tpm: fix invalid locking in NONBLOCKING mode Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb256d5a-5c8c-d5ec-5ad2-ddfaf1c83217@intel.com \
    --to=tadeusz.struk@intel.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jeffrin@rajagiritech.edu.in \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterhuewe@gmx.de \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).