From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>, linux-clk@vger.kernel.org
Cc: tomasz.figa@gmail.com, sboyd@kernel.org, mturquette@baylibre.com,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
b.zolnierkie@samsung.com, m.szyprowski@samsung.com
Subject: Re: [PATCH] clk: samsung: Prevent potential endless loop in the PLL set_rate ops
Date: Fri, 7 Aug 2020 10:32:11 +0900 [thread overview]
Message-ID: <bb483f3c-7d83-4807-aff2-7969a43121aa@samsung.com> (raw)
In-Reply-To: <20200806160646.1997-1-s.nawrocki@samsung.com>
Hi Sylwester,
On 8/7/20 1:06 AM, Sylwester Nawrocki wrote:
> In the .set_rate callback for some PLLs there is a loop polling state
> of the PLL lock bit and it may become an endless loop when something
> goes wrong with the PLL. For some PLLs there is already (duplicated)
> code for polling with a timeout. This patch refactors that code a bit
> and moves it to a common helper function which is then used
> in .set_rate callbacks for all the PLLs.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/clk/samsung/clk-pll.c | 94 +++++++++++++----------------------
> 1 file changed, 35 insertions(+), 59 deletions(-)
>
(snip)
It fix the infinite loop and unify the duplicate code.
It looks good to me. Thanks.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2020-08-07 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200806160653eucas1p2b7fd860f5d89589cf9df0ad0f8d3981f@eucas1p2.samsung.com>
2020-08-06 16:06 ` [PATCH] clk: samsung: Prevent potential endless loop in the PLL set_rate ops Sylwester Nawrocki
2020-08-06 16:11 ` Tomasz Figa
2020-08-07 17:06 ` Sylwester Nawrocki
2020-08-08 17:13 ` Tomasz Figa
[not found] ` <159683164115.1360974.9195158180168134577@swboyd.mtv.corp.google.com>
2020-08-10 16:19 ` Sylwester Nawrocki
2020-08-07 1:32 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb483f3c-7d83-4807-aff2-7969a43121aa@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).