linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2020-10-01 11:53 Stephen Rothwell
  2020-10-01 19:39 ` Anant Thazhemadam
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2020-10-01 11:53 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Anant Thazhemadam

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi all,

In commit

  44d59235ace5 ("Bluetooth: hci_h5: close serdev device and free hu in h5_close")

Fixes tag

  Fixes: https://syzkaller.appspot.com/bug?extid=6ce141c55b2f7aafd1c4

has these problem(s):

  - No SHA1 recognised

Fixes tags normally refer to the commit that is fixed.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bluetooth tree
  2020-10-01 11:53 linux-next: Fixes tag needs some work in the bluetooth tree Stephen Rothwell
@ 2020-10-01 19:39 ` Anant Thazhemadam
  0 siblings, 0 replies; 13+ messages in thread
From: Anant Thazhemadam @ 2020-10-01 19:39 UTC (permalink / raw)
  To: Stephen Rothwell, Marcel Holtmann, Johan Hedberg
  Cc: Linux Kernel Mailing List, Linux Next Mailing List


On 01/10/20 5:23 pm, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   44d59235ace5 ("Bluetooth: hci_h5: close serdev device and free hu in h5_close")
>
> Fixes tag
>
>   Fixes: https://syzkaller.appspot.com/bug?extid=6ce141c55b2f7aafd1c4
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> Fixes tags normally refer to the commit that is fixed.
>
I'm sorry for that.

The commit that was fixed is
    ce945552fde4 (Bluetooth: hci_h5: Add support for serdev enumerated devices)

I'll send in a v2 soon fixing the tag.

Thanks,
Anant


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bluetooth tree
  2024-04-30 21:50 Stephen Rothwell
@ 2024-04-30 22:24 ` Sungwoo Kim
  0 siblings, 0 replies; 13+ messages in thread
From: Sungwoo Kim @ 2024-04-30 22:24 UTC (permalink / raw)
  To: Luiz Augusto von Dentz
  Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
	Linux Kernel Mailing List, Linux Next Mailing List, sfr

Hi, sorry for the wrong fixed tag.

On Tue, Apr 30, 2024 at 5:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   91708e8a4376 ("Bluetooth: msft: fix slab-use-after-free in msft_do_close()")
>
> Fixes tag
>
>   Fixes: 9e14606d8f38 ("Bluetooth: disable advertisement filters during suspend")
>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: bf6a4e30ffbd ("Bluetooth: disable advertisement filters during suspend")
>
> or
>
> Fixes: 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter")

The correct tag is:

Fixes: 5031ffcc79b8 ("Bluetooth: Keep MSFT ext info throughout a
hci_dev's life cycle")

Would you like me to send a new patch to fix this?

Thanks,
Sungwoo.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2024-04-30 21:50 Stephen Rothwell
  2024-04-30 22:24 ` Sungwoo Kim
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2024-04-30 21:50 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Sungwoo Kim, Luiz Augusto von Dentz, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Hi all,

In commit

  91708e8a4376 ("Bluetooth: msft: fix slab-use-after-free in msft_do_close()")

Fixes tag

  Fixes: 9e14606d8f38 ("Bluetooth: disable advertisement filters during suspend")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: bf6a4e30ffbd ("Bluetooth: disable advertisement filters during suspend")

or

Fixes: 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2022-11-09 17:39 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-11-09 17:39 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Ismael Ferreras Morezuelas, Luiz Augusto von Dentz,
	Hans de Goede, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Hi all,

In commit

  14026a4ed275 ("Bluetooth: btusb: Fix CSR clones again by re-adding ERR_DATA_REPORTING quirk")

Fixes tags

  Fixes: 63b1a7dd3 (Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING)
  Fixes: e168f69008 (Bluetooth: btusb: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for fake CSR)
  Fixes: 766ae2422b (Bluetooth: hci_sync: Check LMP feature bit instead of quirk)

have this problem:

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2022-08-31 23:35 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-08-31 23:35 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Sean Wang, Jing Cai, Luiz Augusto von Dentz,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi all,

In commit

  177978b29426 ("Bluetooth: btusb: mediatek: fix WMT failure during runtime suspend")

Fixes tag

  Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for MediaTek

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line (or truncate them).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bluetooth tree
  2022-07-24 21:53 Stephen Rothwell
@ 2022-07-24 21:59 ` Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-07-24 21:59 UTC (permalink / raw)
  To: David Miller
  Cc: Marcel Holtmann, Johan Hedberg, Zhengping Jiang,
	Linux Kernel Mailing List, Linux Next Mailing List, Networking

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Hi all,

On Mon, 25 Jul 2022 07:53:50 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   68253f3cd715 ("Bluetooth: hci_sync: Fix resuming scan after suspend resume")
> 
> Fixes tag
> 
>   Fixes: 3b42055388c30 (Bluetooth: hci_sync: Fix attempting to suspend with
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
> 
> Please do not split Fixes tags over more than one line, just use:
> 
>   git log -1 --format='Fixes: %h ("%s")' <commit>
> 
> Also, please keep all the commit message tags together at the end of
> the commit message.

This is now on the net-next tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2022-07-24 21:53 Stephen Rothwell
  2022-07-24 21:59 ` Stephen Rothwell
  0 siblings, 1 reply; 13+ messages in thread
From: Stephen Rothwell @ 2022-07-24 21:53 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Zhengping Jiang, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi all,

In commit

  68253f3cd715 ("Bluetooth: hci_sync: Fix resuming scan after suspend resume")

Fixes tag

  Fixes: 3b42055388c30 (Bluetooth: hci_sync: Fix attempting to suspend with

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not split Fixes tags over more than one line, just use:

  git log -1 --format='Fixes: %h ("%s")' <commit>

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2022-07-12 22:48 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-07-12 22:48 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Zhengping Jiang, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi all,

In commit

  0cc323d985f9 ("Bluetooth: hci_sync: Fix resuming scan after suspend resume")

Fixes tag

  Fixes: 3b42055388c30 (Bluetooth: hci_sync: Fix attempting to suspend with

has these problem(s):

  - Subject has leading but no trailing parentheses

Please do not break Fixes: tags over more than one line and also keep
all the commit message tas together at the end of the commit message.

Just use

	git log -1 --format='Fixes: %h ("%s")' <commit>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2022-01-06 21:19 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2022-01-06 21:19 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Miaoqian Lin, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

In commit

  6845667146a2 ("Bluetooth: hci_qca: Fix NULL vs IS_ERR_OR_NULL check in qca_serdev_probe")

Fixes tag

  Fixes: 77131dfe ("Bluetooth: hci_qca: Replace devm_gpiod_get() with devm_gpiod_get_optional()")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2021-05-08  2:13 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2021-05-08  2:13 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Connor Abbott, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi all,

In commit

  da68ad722e54 ("Bluetooth: btqca: Don't modify firmware contents in-place")

Fixes tag

  Fixes: 83e8196 ("Bluetooth: btqca: Introduce generic QCA ROME support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2020-07-28 12:24 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2020-07-28 12:24 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Ismael Ferreras Morezuelas

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  cde1a8a99287 ("Bluetooth: btusb: Fix and detect most of the Chinese Bluetooth controllers")

Fixes tag

  Fixes: 81cac64ba258ae (Deal with USB devices that are faking CSR vendor)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* linux-next: Fixes tag needs some work in the bluetooth tree
@ 2020-05-29 12:14 Stephen Rothwell
  0 siblings, 0 replies; 13+ messages in thread
From: Stephen Rothwell @ 2020-05-29 12:14 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zijun Hu

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi all,

In commit

  feac90d756c0 ("Bluetooth: hci_qca: Fix suspend/resume functionality failure")

Fixes tag

  Fixes: 41d5b25fed0 ("Bluetooth: hci_qca: add PM support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-04-30 22:24 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 11:53 linux-next: Fixes tag needs some work in the bluetooth tree Stephen Rothwell
2020-10-01 19:39 ` Anant Thazhemadam
  -- strict thread matches above, loose matches on Subject: below --
2024-04-30 21:50 Stephen Rothwell
2024-04-30 22:24 ` Sungwoo Kim
2022-11-09 17:39 Stephen Rothwell
2022-08-31 23:35 Stephen Rothwell
2022-07-24 21:53 Stephen Rothwell
2022-07-24 21:59 ` Stephen Rothwell
2022-07-12 22:48 Stephen Rothwell
2022-01-06 21:19 Stephen Rothwell
2021-05-08  2:13 Stephen Rothwell
2020-07-28 12:24 Stephen Rothwell
2020-05-29 12:14 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).