From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C883DC33C9B for ; Tue, 7 Jan 2020 10:57:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A845E20678 for ; Tue, 7 Jan 2020 10:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbgAGK5M (ORCPT ); Tue, 7 Jan 2020 05:57:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:59298 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbgAGK5L (ORCPT ); Tue, 7 Jan 2020 05:57:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 72E95AD05; Tue, 7 Jan 2020 10:57:09 +0000 (UTC) Message-ID: Subject: Re: [PATCH 05/13] mailbox: bcm2835: convert to devm_platform_ioremap_resource From: Nicolas Saenz Julienne To: Yangtao Li , jassisinghbrar@gmail.com, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, lftan@altera.com, matthias.bgg@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, nios2-dev@lists.rocketboards.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Date: Tue, 07 Jan 2020 11:57:07 +0100 In-Reply-To: <20191228183538.26189-5-tiny.windzz@gmail.com> References: <20191228183538.26189-1-tiny.windzz@gmail.com> <20191228183538.26189-5-tiny.windzz@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-y5AsCnHtvQY7mJ+3+eeo" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-y5AsCnHtvQY7mJ+3+eeo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. >=20 > Signed-off-by: Yangtao Li > --- Reviewed-by: Nicolas Saenz Julienne Thanks! > drivers/mailbox/bcm2835-mailbox.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835- > mailbox.c > index 39761d190545..79f93c9c7682 100644 > --- a/drivers/mailbox/bcm2835-mailbox.c > +++ b/drivers/mailbox/bcm2835-mailbox.c > @@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device > *pdev) > { > struct device *dev =3D &pdev->dev; > int ret =3D 0; > - struct resource *iomem; > struct bcm2835_mbox *mbox; > =20 > mbox =3D devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL); > @@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device > *pdev) > return -ENODEV; > } > =20 > - iomem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > - mbox->regs =3D devm_ioremap_resource(&pdev->dev, iomem); > + mbox->regs =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mbox->regs)) { > ret =3D PTR_ERR(mbox->regs); > dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret); --=-y5AsCnHtvQY7mJ+3+eeo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl4UZAMACgkQlfZmHno8 x/5XXwgAlWhWoPbAnKlacluRU3wwe6Bf/fyJCILvfBL9w8HbTcoFBOIX1v57lLdQ vd8AzkmNgkzmUYyMOpKcyUI6+YQDgtc4qKutzeA7fLNS5oo2b0XB3tRwZa1ng1oJ vknawhQvjlzIjfNNzO5UKIVWgSoVqZlHmuQyuRN6pemg9IgT7VaEEL/rEo1uOkix eCyerYBXqS8Y5Ty0Y7KOjrDM2wFiggH/r6Y4mt+2Mto5pZDbY4CtBD1JjSb4u8eS 8TF9+Pf7Jqh/NW0xAz1x40aq+J77rPsKecWm96kWnJBTUyTx4Seh6mHsZQl1Nxej fZAJaanhMv0nlXusFg/vtaSBr94lkQ== =bWd1 -----END PGP SIGNATURE----- --=-y5AsCnHtvQY7mJ+3+eeo--