From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932511AbcLRTS5 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 18 Dec 2016 14:18:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36206 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758694AbcLRTS4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 18 Dec 2016 14:18:56 -0500
Subject: Re: [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges
To: Chen-Yu Tsai <wens@csie.org>
References: <20161216200906.10028-1-hdegoede@redhat.com>
 <20161216200906.10028-2-hdegoede@redhat.com>
 <CAGb2v64-0qhBJ5nFTtV2rEL5Bw+KrP2V1h-6wv1XQibDgzag2Q@mail.gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
        "russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
        linux-kernel <linux-kernel@vger.kernel.org>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <bb6d8e9c-2683-7ea2-c4a3-a40b429dfdfe@redhat.com>
Date: Sun, 18 Dec 2016 20:18:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <CAGb2v64-0qhBJ5nFTtV2rEL5Bw+KrP2V1h-6wv1XQibDgzag2Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 18 Dec 2016 19:18:56 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 17-12-16 16:12, Chen-Yu Tsai wrote:
> On Sat, Dec 17, 2016 at 4:09 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> The axp288 pmic has a lot more volatile registers then we were
>> listing in axp288_volatile_ranges, fix this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Thank you.

> FYI, if you're going to add support for the battery charger detection
> module later,

That driver is already in mainline, but like the other axp288 drivers
it needs some love to actual successfully probe and work, I've a set
of patches for ready for this, since I've been successfully testing
them the last few days I guess I might as well send them now,
so expect some patches for this soon :)

  you would need to add the remaining AXP288_BC_* registers
> to the writable table.

The writeable table contains:
	regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ6_STATE),

Which already includes all of the BC registers.

Regards,

Hans