[PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

[PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

[Ferry Toth]

On Intel Merrifield LPM is causing the host to reset port after a timeout.
By disabling LPM entirely this is prevented.

Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/usb/dwc3/dwc3-pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 4c5c6972124a..e5d7eed2e60c 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -122,6 +122,7 @@ static const struct property_entry dwc3_pci_mrfld_properties[] = {
 	PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
 	PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
 	PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),
+	PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"),
 	PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
 	{}
 };
-- 
2.27.0

Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Ferry Toth <ftoth@exalondelft.nl> writes:

> On Intel Merrifield LPM is causing the host to reset port after a timeout.
> By disabling LPM entirely this is prevented.
>
> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
> Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

[Greg Kroah-Hartman]

On Sun, Apr 25, 2021 at 09:54:52PM +0200, Ferry Toth wrote:
> On Intel Merrifield LPM is causing the host to reset port after a timeout.
> By disabling LPM entirely this is prevented.
> 
> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
> Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-pci.c | 1 +
>  1 file changed, 1 insertion(+)

What changed from v1?  Always put that below the --- line.

Re: [PATCH v2 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield

[Ferry Toth]

Hi,


Op 10-05-2021 om 14:40 schreef Greg Kroah-Hartman:
> On Sun, Apr 25, 2021 at 09:54:52PM +0200, Ferry Toth wrote:
>> On Intel Merrifield LPM is causing the host to reset port after a timeout.
>> By disabling LPM entirely this is prevented.
>>
>> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
>> Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>>   drivers/usb/dwc3/dwc3-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
> What changed from v1?  Always put that below the --- line.
>
Yes, my bad, sorry.

In the above text "is causing host" was change to "is causing the host".

Thanks for adding into your usb-linus branch anyway.