From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2CFDC6FA90 for ; Wed, 21 Sep 2022 18:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiIUS6f (ORCPT ); Wed, 21 Sep 2022 14:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbiIUS6b (ORCPT ); Wed, 21 Sep 2022 14:58:31 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D51AA1D47 for ; Wed, 21 Sep 2022 11:58:29 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id a3so10749519lfk.9 for ; Wed, 21 Sep 2022 11:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=i0GvNHAA6HriUK1iwHQhuKbfhvmDlYsJZtxUwtDszrU=; b=tyQxrwTx7FC0WMK4iNa0xMT5ZTkUNUXRjuYJ6ngr8504lz1m287MotseKwIv4+vIkw t7ydFQuNkDAN8HycVQ460BqRkotr6Dtu2XLxAznWv5gwKqQRTi9apNCAKpX2xeaeagN8 C0J2zzWG1pdBm7brCVJs+eEAC4hXKE7+J1xJa1y4JrNtdo6H54TdR+ps2n7gQPbCG754 Qle8zKu4I113dnuI17fY6ZicPB0FC3+nDac3X9PV1A3Of81mKNa+rT2ooMnLvM262f7c oCzVykwGdjm/VXCbZxmN4rtgQfZWLfQjLGBkGTeSsz4dBrX6dayd+H+6ptW3DZyWtkw6 m4dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=i0GvNHAA6HriUK1iwHQhuKbfhvmDlYsJZtxUwtDszrU=; b=AzVtgYHAKusRvpGT/Jm1bLs6S9ht0OIqIOMMHAYOMETIXHkowRlJxcmxohx7lNFmJ4 4k5wOd9Q6Kpv6BlKWMgdCkQoIia904Q53yA8csuubKJK5Xniuma1CbrkzCcx+TIlGzCM Awf0WFkR0yzPcUZtzGWaPkLBPIiybE1bqo7Y7eaGPa1I+E9Wa6CULejAhySjLIP4fye6 d3cl5qndbdDQxGpHO3MsiLJ+Aa4XPTSmO5RFYmBQOsanHuTFU3KetEeG6L25Vv41vybl yfx+L8nC7/PtdQeVVR0RjfnWS+m1Wn0Zrph8e/TAoldY+IiLfYm+XcpYhQrYhDSot7hE VfHg== X-Gm-Message-State: ACrzQf0EqkbRzyND84OmwXCEfQlVKpyvWX1ZBfx+nKn3I7yw5soEUkEG X/029hABvBpMzT0XOGUAKmWWqg== X-Google-Smtp-Source: AMsMyM7BFiYVamvKMGfRkSVY1bQDxJm0JXW9wMgz8WbyWhMSAHmN5EjwbxsFX4D044b8XvGAD77rwg== X-Received: by 2002:ac2:5b0f:0:b0:49c:949e:d8f7 with SMTP id v15-20020ac25b0f000000b0049c949ed8f7mr10203910lfn.336.1663786707635; Wed, 21 Sep 2022 11:58:27 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l6-20020ac25546000000b00492ce573726sm559891lfk.47.2022.09.21.11.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 11:58:27 -0700 (PDT) Message-ID: Date: Wed, 21 Sep 2022 20:58:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block Content-Language: en-US To: Laurent Pinchart Cc: Lad Prabhakar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Sakari Ailus , Hans Verkuil , Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <29d456ed-620c-8dc9-01f0-54f96b670b94@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 19:29, Laurent Pinchart wrote: >>>>> + clock-names: >>>>> + items: >>>>> + - const: vclk >>>>> + - const: pclk >>>>> + - const: aclk >>>> >>>> Drop the "clk" suffixes. Remaining names could be made a bit more readable. >>> >>> These names come from the documentation, isn't it better to match the >>> datasheet ? >> >> If datasheet calls it "vclk_really_clk_it_is_clk_clk", it's not the >> reason to use it. :) >> >> The "clk" is redundant even if the hardware engineer thought different. >> >> The same for IRQs ("tx" not "txirq"), for dmas ("tx" not "txdma"). > > I'd argue that naming clocks "v", "p" and "a" would be less readable and > more confusing. Is this a new rule ? Not really, but also it's only a style issue. Indeed "v" and "p" are not much better... but still "vclk" does not bring any additional information over "v". It's redundant. You can also drop entire entry - unless it helps in particular implementation. https://lore.kernel.org/all/20220517175958.GA1321687-robh@kernel.org/ https://lore.kernel.org/all/20210815133926.22860-1-biju.das.jz@bp.renesas.com/ https://lore.kernel.org/all/YYFCaHI%2FDASUz+Vu@robh.at.kernel.org/ https://lore.kernel.org/all/20220830182540.GA1797396-robh@kernel.org/ Best regards, Krzysztof